Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nested comments not supported by NVHPC compiler #78

Open
GuillaumeLscrt opened this issue Feb 13, 2024 · 1 comment
Open

Nested comments not supported by NVHPC compiler #78

GuillaumeLscrt opened this issue Feb 13, 2024 · 1 comment

Comments

@GuillaumeLscrt
Copy link

This type of comment is not supported by the NVHPC 23.11 C compiler.

/*OMPI_DECLSPEC int*/ void * OMPI_C_MPI_NULL_DELETE_FN;/*( A_MPI_Comm comm, int comm_keyval,
                                             void* attribute_val_out,
                                             void* extra_state )
                                             __mpi_interface_deprecated__;/*("A_MPI_NULL_DELETE_FN is deprecated in MPI-2.0");*/

It appears in the following files at line 847, 853 and 859:

src/preload/header/OMPI_INTEL/app_mpi.h
src/preload/header/OMPI_MPICH/app_mpi.h

The fix consists in the removal of /* after __mpi_interface_deprecated__;.

@kevin-juilly
Copy link

Nested comments are effectively unsupported in C. But since there is no additional closing sequence, it's supposed to be valid code.
NVHPC did issue warnings when I used it. Unless you pass the -Werror, it is not really an issue.
FYI, gcc -Wall would give a similar warning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants