Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Funding Request - Release 79.1.x #3013

Closed
9 tasks done
amaitland opened this issue Jan 13, 2020 · 17 comments
Closed
9 tasks done

Funding Request - Release 79.1.x #3013

amaitland opened this issue Jan 13, 2020 · 17 comments
Assignees
Milestone

Comments

@amaitland
Copy link
Member

amaitland commented Jan 13, 2020

As always a big thank you to those who have contributed previously and especially those who make recurring contributions through BountySource Salt and GitHub Sponsors.

Again I'm asking for funding to continue my work on maintaining/developing CefSharp. As some of you may well know I'm currently a stay at home dad and spend a fairly large amount of time (roughly 10-12hrs per week) developing and supporting the project. Your contributions are the only reason I'm allowed to continue working on the project. Without continued funding the time I currently spend on the project will have to be put into finding other paid work.

There are multiple options for contributing at this time:

If you'd like to made a donation through Paypal directly or signup to GitHub Sponsors, I'll happily reduce the target.


Release 79.1.310-pre

When 50% of target reached

  • Update to latest CEF build
  • Create release notes
  • Update changelog wiki
  • Create cefsharp/79 release branch
  • Release -pre pacakges to nuget.org

Release 79.1.350

When 100% of target reached

If three additional people signup to GitHub Sponsors then I'll look at releasing a new more modern set of Nuget Packages which will better support .Net Core 3.x See #2795 for proposed package details.


If there's a particular issue you'd like to see resolved and are willing to contribute financial support then I'm happy to discuss the feasibility.

@amaitland amaitland added this to the 79.0.0 milestone Jan 13, 2020
@amaitland amaitland self-assigned this Jan 13, 2020
@amaitland amaitland pinned this issue Jan 13, 2020
@matthias-hoste
Copy link

Why didn't you say so right away! Here you are, thank you for your massive work and have fun with the baby^^ hope you are not on night duty

@jankurianski
Copy link
Member

Done! Thanks for your hard work Alex. CefSharp is critical to my company's products so we are keen to see you continue your efforts. It's great that GitHub is matching contributions too.

We're particularly interested in this 79.0 release as I understand it comes with a new OSR architecture (Viz). Hoping that it helps with performance and occasional (very hard to reproduce) rendering freezes - once the inevitable bugs come under control.

@amaitland
Copy link
Member Author

Why didn't you say so right away! Here you are, thank you for your massive work and have fun with the baby^^ hope you are not on night duty

@lifecoder-phoenix Thank you! Greatly appreciated. I get the sunrise shift as my almost two year old toddler insist on getting up before the sun rises ☹️

I've done a little more on the new set of Nuget packages, I should have a detailed report of the roadblocks I've found and hopefully a potential path forward shortly.

Done! Thanks for your hard work Alex. CefSharp is critical to my company's products so we are keen to see you continue your efforts. It's great that GitHub is matching contributions too.

@jankurianski Thank you for the continued and generous support! Greatly appreciated!

We're particularly interested in this 79.0 release as I understand it comes with a new OSR architecture (Viz). Hoping that it helps with performance and occasional (very hard to reproduce) rendering freezes - once the inevitable bugs come under control.

The Viz Compositor is now supported, though there are a few issues still so I'll ship 79 with disable-gpu-compositing set by default to workaround the following:

Version 75.1.14x also shipped with GPU Compositing disabled. Performance should still be improved.

Switching rapidly between browsers in a tabbed scenario (Issue #2779) also appears to be fixed, so I haven't applied the hack used in 75.1.14x as yet. If I get further reports I'll apply the same workaround. Chromium removed the breakpoint/assertion from their code that was very very rarely causing a crash (hard crash, so you'd know if this was something you were experiencing).

For WPF a very minor improvement has been made in commit b1bd749#diff-8539a334a2bc5cd26a33a8f953f674c1 where a new buffer is only allocated if the current buffer is too small.

I've also added CefSharp.Wpf.Rendering.Experimental.CompositionTargetRenderHandler which I'm hopeful will yield some performance improvements (I haven't had a real world scenario to test this out, so It comes with the experimental label for now). The WPF Bitmap is only updated when WPF performs it's rendering in the
CompositionTarget.Rendering event. If you choose to go down this path then let me know and we can see about ironing out any remaining issues.

@amaitland
Copy link
Member Author

master was updated to CEF 79.1.31+gfc9ef34+chromium-79.0.3945.117 / Chromium 79.0.3945.117 in commit 1550251

@jankurianski
Copy link
Member

The Viz Compositor is now supported, though there are a few issues still so I'll ship 79 with disable-gpu-compositing set by default to workaround the following:

Cool, thanks for letting me know. Those CEF issues describe using OSR in a similar way to myself. I am using a pool of ChromeOffScreen instances in different threads to take screenshots. They are frequently resizing the window and changing the zoom factor. Looks like I am inviting trouble! I have set the disable-gpu-compositing flag also.

@amaitland
Copy link
Member Author

I have set the disable-gpu-compositing flag also.

@jankurianski I've also disabled GPU Compositing for OffScreen by default. I haven't see any resizing issues yet with GPU Compositing disabled. Please let me know if you experience any problems.

@matthias-hoste
Copy link

@amaitland thanks for the updates! And ah yes toddlers, always want to wake up early and in 12 years they don't want to wake up before noon^^

@appakz
Copy link

appakz commented Jan 21, 2020

Sorry if this is apparent and I'm just missing it, but what is the target amount? How much do you have left to raise?

@amaitland
Copy link
Member Author

Thanks to Galvanize the revised target has been reached!

Galvanize


The follow 79.1.310-pre packages are available on Nuget.org

You can use the MinimalExample for testing purposes, there is a specific branch that's been updated see https://github.com/cefsharp/CefSharp.MinimalExample/tree/cefsharp/79

The release notes are available at https://github.com/cefsharp/CefSharp/releases/tag/v79.1.310-pre

@amaitland
Copy link
Member Author

Sorry if this is apparent and I'm just missing it, but what is the target amount? How much do you have left to raise?

@appakz A valid question and unfortunately it doesn't appear to be visible on BountySource anymore. I'll look at making things clearer for the next release.

@amaitland
Copy link
Member Author

The API Doc has been generated is now available at http://cefsharp.github.io/api/79.1.x/

@amaitland
Copy link
Member Author

Version 79.1.350 is now available

Release notes are available at https://github.com/cefsharp/CefSharp/releases/tag/v79.1.350

The MinimalExample has been updated.

A CEF issue related to ResourceHandler usage was fixed this morning, so I'll probably release another bug fix version in a week or so. https://bitbucket.org/chromiumembedded/cef/issues/2843/race-condition-in-openinputstreamwrapper

@amaitland
Copy link
Member Author

A new milestone has been created for the upcoming bug fix release, a few minor things have been resolved.

I'm waiting to see if some of the OSR bugs in CEF will be fixed before updating, see https://bitbucket.org/chromiumembedded/cef/pull-requests/284/fix-for-issue-2733-incorrect-osr-rendering/diff#comment-134286689 for details.

@TonyValenti
Copy link

@amaitland -
Will this release support .NET Core? We're looking to port from .NET 4.6.1 to .NET Core 3.x and this is one of the last remaining libraries that we need converted.

@amaitland
Copy link
Member Author

@TonyValenti It is already possible to use CefSharp with .Net Core as detailed at #2796 (comment) See https://github.com/cefsharp/CefSharp.MinimalExample for a working example.

@riksking
Copy link

A new milestone has been created for the upcoming bug fix release, a few minor things have been resolved.

I'm waiting to see if some of the OSR bugs in CEF will be fixed before updating, see https://bitbucket.org/chromiumembedded/cef/pull-requests/284/fix-for-issue-2733-incorrect-osr-rendering/diff#comment-134286689 for details.

@amaitland can you release "bug-fix" version without waiting fix of the "OSR" bugs?
We need to get fix for this bug.

@amaitland amaitland changed the title Funding Request - Release 79.0.0 Funding Request - Release 79.1.x Feb 11, 2020
@amaitland amaitland unpinned this issue May 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants