Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace start and end block range with nonce in the DataCommitmentConfirms #248

Closed
Tracked by #301
evan-forbes opened this issue Mar 14, 2022 · 3 comments
Closed
Tracked by #301

Comments

@evan-forbes
Copy link
Member

Currently we are using a block range for each data commitment. We should instead replace this with a nonce, as this is more in line with what the contracts expect. This will make relaying and slashing easier.

@rach-id
Copy link
Member

rach-id commented Mar 14, 2022

I guess, if we go for a nonce, it is better if we separate:
MsgDataCommitment and MsgDataCommitmentConfirm, similar to what ValSet and ValSetConfirm do, with the prior containing a nonce and the latter reference to it.
What do you think ?

@evan-forbes
Copy link
Member Author

yeah, that makes sense! Following the pattern is a good idea. We will likely also follow the ValsetRequest pattern too in order to accomodate celestiaorg/blobstream-contracts#54 and #332

@evan-forbes
Copy link
Member Author

can close since we switched to universal nonces

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

No branches or pull requests

3 participants