Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate ShareProof from app #3734

Open
rach-id opened this issue Jul 25, 2024 · 0 comments
Open

Remove duplicate ShareProof from app #3734

rach-id opened this issue Jul 25, 2024 · 0 comments
Assignees
Labels
warn:api breaking item will be break an API and require a major bump

Comments

@rach-id
Copy link
Member

rach-id commented Jul 25, 2024

Currently, we have 2 definitions of ShareProof, one in core https://github.com/celestiaorg/celestia-core/blob/v0.34.x-celestia/types/share_proof.go and one in app https://github.com/celestiaorg/celestia-app/blob/main/pkg/proof/proof.pb.go. This makes a confusion when using these types downstream and ultimately requires introducing functions to convert one to the other.

Since ShareProof needs to exist in core because it is part of the transaction proof: https://github.com/celestiaorg/celestia-core/blob/dae3ca9d106c9b27dc192202e052ee0b234f645d/rpc/core/types/responses.go#L225-L232, we should remove its definition from app.

@rach-id rach-id added the warn:api breaking item will be break an API and require a major bump label Jul 25, 2024
@rach-id rach-id assigned rach-id and unassigned rach-id Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
warn:api breaking item will be break an API and require a major bump
Projects
None yet
Development

No branches or pull requests

2 participants
@rach-id and others