Override the timeout_commit and timeout_propose when switching to v3

[evan-forbes]

We should override the timeouts upon the switch to app version v3

[rootulp]

Context

• ADR-115 Predictable Block Times

Validator's locally configure these timeouts in config.toml:

# How long we wait for a proposal block before prevoting nil
timeout_propose = "10s"
# How much timeout_propose increases with each round
timeout_propose_delta = "500ms"
# How long we wait after receiving +2/3 prevotes for “anything” (ie. not a single block or nil)
timeout_prevote = "1s"
# How much the timeout_prevote increases with each round
timeout_prevote_delta = "500ms"
# How long we wait after receiving +2/3 precommits for “anything” (ie. not a single block or nil)
timeout_precommit = "1s"
# How much the timeout_precommit increases with each round
timeout_precommit_delta = "500ms"
# How long we wait after committing a block, before starting on the new
# height (this gives us a chance to receive some more precommits, even
# though we already have +2/3).
timeout_commit = "11s"

Problem

We'd like to decrease the block time from ~11.75 seconds to ~6 seconds at the same time that celestia-app v3 gets deployed to networks.

We don't want to rely on validator's manually configuring timeouts in their config.toml because we can't guarantee that they will be modified at the same time. Therefore, we'd like to add ADR-115's next_block_delay as a field in EndBlockResponse. If it exists, use that instead of timeout commit.

Proposal

Backport ADR-115 to celestia-core

Related

• @staheri14 did some investigation into delayed voting. AFAICT no implementation changes are being included in v3 but this issue likely has impact on her work.
• CIP-23 Coordinated Prevote times

[rootulp]

Notes from discussion w/ @evan-forbes :

• This issue diverges from ADR-115 because we want to override two params not just one (as proposed in ADR-115).
• This is blocked on experiments for determining what the values are.
  • @evan-forbes hypothesizes that TimeoutCommit = ~4.7 seconds and TimeoutProposal = ~3.5 seconds.
  • @evan-forbes teach @rootulp how to run experiment to determine the correct timeouts. Blocked on @evan-forbes syncing with @sysrex because he's currently using his personal accounts for Congest.