Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add share version 1 to specs #3867

Open
rootulp opened this issue Sep 12, 2024 · 0 comments
Open

Add share version 1 to specs #3867

rootulp opened this issue Sep 12, 2024 · 0 comments
Labels
nice to have item is not blocking or required. specs directly relevant to the specs WS: V3 3️⃣ item is directly relevant to the v3 hardfork
Milestone
v3

Comments

@rootulp
Copy link
Collaborator

rootulp commented Sep 12, 2024

Context

The only supported share version is 0.

See https://celestiaorg.github.io/celestia-app/shares.html#share-version

Problem

The specs don't describe share version 1 which introduces the signer. Share version 1 was introduced in https://github.com/celestiaorg/go-square/releases/tag/v2.0.0-rc0

Proposal

Update the specs with share version 1
@rootulp rootulp added specs directly relevant to the specs WS: V3 3️⃣ item is directly relevant to the v3 hardfork labels Sep 12, 2024
@rootulp rootulp added this to the v3 milestone Sep 12, 2024
@evan-forbes evan-forbes added the nice to have item is not blocking or required. label Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
nice to have item is not blocking or required. specs directly relevant to the specs WS: V3 3️⃣ item is directly relevant to the v3 hardfork
Projects
None yet
Milestone
v3
Development

No branches or pull requests
2 participants
@rootulp @evan-forbes