Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in tx_indexer config #1450

Open
rootulp opened this issue Jul 24, 2024 · 3 comments
Open

Bug in tx_indexer config #1450

rootulp opened this issue Jul 24, 2024 · 3 comments

Comments

@rootulp
Copy link
Collaborator

rootulp commented Jul 24, 2024

Context

I was trying to figure out the steps we should provide DevOps on how to disable the kv indexer and enable the lightweight transaction indexer.

Problem

On celestia-app v1.12.0, config.toml looks like this

# Options:
#   1) "null"
#   2) "kv" (default) - the simplest possible indexer, backed by key-value storage (defaults to levelDB; see DBBackend).
# 		- When "kv" is chosen "tx.height" and "tx.hash" will always be indexed.
#   3) "psql" - the indexer services backed by PostgreSQL.
# When "kv" or "psql" is chosen "tx.height" and "tx.hash" will always be indexed.
indexer = "null"

On celestia-app v1.13.0, config.toml looks like this:

# Options:
#   1) "kv"
#   2) "kv" (default) - the simplest possible indexer, backed by key-value storage (defaults to levelDB; see DBBackend).
# 		- When "kv" is chosen "tx.height" and "tx.hash" will always be indexed.
#   3) "psql" - the indexer services backed by PostgreSQL.
# When "kv" or "psql" is chosen "tx.height" and "tx.hash" will always be indexed.
indexer = "kv"

Acceptance Criteria

  1. Fix the config so that there aren't two "kv" options. I think the first option should be "null".
  2. [Tangent] Provide steps to DevOps on how to enable the lightweight tx indexer

cc: @ninabarbakadze

@cmwaters
Copy link
Contributor

cmwaters commented Aug 5, 2024

I think we should remove the (default) part (since we actually default to null)

@cmwaters
Copy link
Contributor

cmwaters commented Aug 5, 2024

Also I think this issue should be in celestia-core

@rootulp rootulp transferred this issue from celestiaorg/celestia-app Aug 5, 2024
@rootulp
Copy link
Collaborator Author

rootulp commented Aug 5, 2024

Moved to celestia-core. I propose we move the (default) part to null then. So the desired config would look like:

# Options:
#   1) "null" (default)
#   2) "kv" - the simplest possible indexer, backed by key-value storage (defaults to levelDB; see DBBackend).
# 		- When "kv" is chosen "tx.height" and "tx.hash" will always be indexed.
#   3) "psql" - the indexer services backed by PostgreSQL.
# When "kv" or "psql" is chosen "tx.height" and "tx.hash" will always be indexed.
indexer = "null"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants