Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

makefile: Report correct tag in binary version #3820

Open
Wondertan opened this issue Oct 7, 2024 · 1 comment
Open

makefile: Report correct tag in binary version #3820

Wondertan opened this issue Oct 7, 2024 · 1 comment

Comments

@Wondertan
Copy link
Member

If there are several tags on the same commit(like -arabica and -mocha) it will always give the latest tag, even if you do git checkout tags/<tag> on a specific tag.

It's unclear to me right now how to solve that. One of the options is to ensure different tags are never on the same commit, but there might be an easier way.

@rootulp
Copy link
Contributor

rootulp commented Oct 15, 2024

I don't expect this to work in 100% of cases but I think it's an improvement over the current buggy version reporting: celestiaorg/celestia-app#3977

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants