Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

service/header/core_listener: Ensure core node connection is not syncing before publishing headers to headersub #499

Closed
renaynay opened this issue Mar 7, 2022 · 0 comments · Fixed by #549
Assignees
Labels
area:core_and_app Relationship with Core node and Celestia-App area:header Extended header

Comments

@renaynay
Copy link
Member

renaynay commented Mar 7, 2022

Problem

Old block headers (those older than network head) are getting spammed to headersub.

image

Solution

In order to prevent the spamming of old block headers to headersub, Bridge nodes should ensure that their running celestia-core node connection is NOT syncing before publishing new ExtendedHeaders to headersub.

This can be done by only launching the listen loop after the core.BlockFetcher is not syncing. A new method can be implemented for BlockFetcher to return whether core connection is syncing or not and the listen loop can wait to launch until it is no longer syncing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:core_and_app Relationship with Core node and Celestia-App area:header Extended header
Projects
No open projects
Archived in project
1 participant