Skip to content
This repository has been archived by the owner on Apr 30, 2024. It is now read-only.

Ethermint uses Tendermint Hashes #71

Open
jbowen93 opened this issue Jul 1, 2022 · 2 comments · May be fixed by #70
Open

Ethermint uses Tendermint Hashes #71

jbowen93 opened this issue Jul 1, 2022 · 2 comments · May be fixed by #70
Assignees

Comments

@jbowen93
Copy link

jbowen93 commented Jul 1, 2022

Currently Ethermint uses Tendermint hashes for blocks. This is problematic because when Optimism retrieves a block it validates its header https://github.com/celestiaorg/optimism/blob/develop/op-node/l1/types.go#L113

if computed := header.header.Hash(); computed != info.hash

These hashes do not match

@jbowen93 jbowen93 self-assigned this Jul 1, 2022
@jbowen93 jbowen93 linked a pull request Jul 11, 2022 that will close this issue
@jbowen93
Copy link
Author

I'm going to attempt to create a middleware layer that converts Ethereum hashes to Tendermint hashes prior to passing retrieve call to Optimint/Tendermint.

@jbowen93
Copy link
Author

The best way to move forward here is to include both the tendermint hash and the ethereum hash on each block. Then we can create an index between the two.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant