Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish a @celo/contracts and @celo/abis #10290

Closed
nicolasbrugneaux opened this issue May 3, 2023 · 8 comments · Fixed by #10297
Closed

Publish a @celo/contracts and @celo/abis #10290

nicolasbrugneaux opened this issue May 3, 2023 · 8 comments · Fixed by #10297
Assignees

Comments

@nicolasbrugneaux
Copy link
Contributor

nicolasbrugneaux commented May 3, 2023

Following discussions with @martinvol and @0xarthurxyz , it would be useful for mento to have the ability to import the core celo contracts directly in solidity.

In order to do so they'd need

  • the @celo/contracts to be updated on a regular basis (ideally on push to master)
  • a @celo/abis to be created and populated with the build directory content of the protocol package

Versioning:

  • @celo/contracts and abis should follow the core contract versioning (eg: they're on v8 right now and working on v9) so the npm package should be 8.x

Automation:

  • contracts and abis can be published with the prerelease tag on push/merge to master
  • for now, because the core contracts release process is still quite manual, the latest tag cannot be automated, but should be "easy" to do (npm dist-tag could be run by whomever releases core contracts?)
@nicolasbrugneaux
Copy link
Contributor Author

Previous related work 7554

@aaronmgdr
Copy link
Member

probably makes sense if they both follow same versioning

@nicolasbrugneaux
Copy link
Contributor Author

Published both @celo/contracts@beta and @celo/abis@beta manually and a PR with the automation for the publishing on push to master will be opened

@nicolasbrugneaux
Copy link
Contributor Author

PR WIP here: #10297

@nicolasbrugneaux
Copy link
Contributor Author

nicolasbrugneaux commented May 9, 2023

State of the issue:

Image

  • Ownership is now with the Primitive team on usage. We consider our contribution done, with that being said, we stay available to help to add the env variable if needed! :)

@nicolasbrugneaux
Copy link
Contributor Author

Changing issue status to blocked as per the msg above.

@nicolasbrugneaux
Copy link
Contributor Author

nicolasbrugneaux commented May 10, 2023

And published types with the abis as of @celo/[email protected]

@arthurgousset arthurgousset changed the title Publish a @celo/contracts and @celo/contracts-abis Publish a @celo/contracts and @celo/abis Aug 30, 2023
@arthurgousset
Copy link
Contributor

Closing this ticket because the packages are published and can be used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants