Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update progress bar component to accept custom color indicator #1333

Open
orion-cengage opened this issue Jun 26, 2024 · 4 comments
Open

Update progress bar component to accept custom color indicator #1333

orion-cengage opened this issue Jun 26, 2024 · 4 comments
Assignees
Labels
feature request Functionality that you believe is missing that you want added react-magma-dom Tasks related to react-magma-dom

Comments

@orion-cengage
Copy link
Contributor

orion-cengage commented Jun 26, 2024

Purpose: Allow consumers to change the indicator of the progress bar to any custom color they want, in addition to our presets.

image

AC

  • Allow consumer to use a string like "#B12FAD" to set the color of the indicator.
  • Make sure the track can still not be changed.
  • How can we handle allowing a different color set when Inversed?
@orion-cengage orion-cengage added react-magma-dom Tasks related to react-magma-dom feature request Functionality that you believe is missing that you want added labels Jun 26, 2024
@silvalaura
Copy link
Collaborator

Make a note in the docs site that, when using custom colors, they must be checked for color contrast for a11y.

@silvalaura
Copy link
Collaborator

Create an example that swaps between using chartColorsInverse and chartColors depending on whether the ProgressBar is using inverse.

@orion-cengage
Copy link
Contributor Author

QA complete - Update to progress bar and documentation looks great.

@chris-cedrone-cengage
Copy link
Collaborator

Looks good here!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Functionality that you believe is missing that you want added react-magma-dom Tasks related to react-magma-dom
Projects
Status: Done
Development

No branches or pull requests

3 participants