Skip to content
This repository has been archived by the owner on Oct 3, 2023. It is now read-only.

Remove @ts-expect-error comments from TS 3.x migration #910

Open
aabmass opened this issue Jul 19, 2021 · 2 comments
Open

Remove @ts-expect-error comments from TS 3.x migration #910

aabmass opened this issue Jul 19, 2021 · 2 comments

Comments

@aabmass
Copy link
Member

aabmass commented Jul 19, 2021

I used the ts-migrate script to add @ts-expect-error to silence new TS errors introduced in migration from TypeScript 2.x to 3.x (#907). For example

// @ts-expect-error ts-migrate(2345) FIXME: Argument of type 'IArguments' is not assignable to... Remove this comment to see the full error message

Definitive list: https://github.com/census-instrumentation/opencensus-node/search?q=ts-migrate

@alaminShaheen
Copy link

There are more than 20 such comments. Do you want all of them removed?

@aabmass
Copy link
Member Author

aabmass commented Oct 14, 2021

Yes if possible, but it's low priority as this project has been mostly superseded by OpenTelemetry 🙂 Would you like to help out on this?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants