Skip to content
This repository has been archived by the owner on Oct 3, 2023. It is now read-only.

Should tag values be less restrictive? #53

Closed
semistrict opened this issue Feb 27, 2018 · 3 comments
Closed

Should tag values be less restrictive? #53

semistrict opened this issue Feb 27, 2018 · 3 comments
Assignees

Comments

@semistrict
Copy link
Contributor

Tag values as specified in tags/TagContext.md are as restrictive as keys:

TagKey
A string or string wrapper, with some restrictions:

Must contain only printable ASCII (codes between 32 and 126, inclusive).
Must have length greater than zero and less than 256.
TagValue
A string or string wrapper with the same restrictions as TagKey, except that it is allowed to be empty.

This seems too restrictive. Common metrics backends seem to support arbitrary values:

Also I would guess that it would be very inconvenient for non-latin languages where you could imagine things like city names being in tag values (for example). I would be very frustrated if the backend I'm using supports my native language characters but I'm forced to encode everything just because OpenCensus creates an artificial restriction.

@codefromthecrypt
Copy link

codefromthecrypt commented Feb 27, 2018 via email

@sebright
Copy link
Contributor

/cc @dinooliva

@songy23
Copy link
Contributor

songy23 commented Apr 25, 2019

Obsolete.

@songy23 songy23 closed this as completed Apr 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants