Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

Update LDAP parameters #280

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Update LDAP parameters #280

wants to merge 3 commits into from

Conversation

dtrdnk
Copy link

@dtrdnk dtrdnk commented Dec 2, 2022

…From for loading env from secrets, and subsets them. Fix LDAP parameters

What this PR does / why we need it:

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

  • fixes #

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md

@banzo banzo self-requested a review December 2, 2022 14:30
@banzo banzo added the enhancement New feature or request label Dec 2, 2022
@dtrdnk dtrdnk force-pushed the master branch 2 times, most recently from 166bee6 to f7c9072 Compare December 6, 2022 14:56
@dtrdnk dtrdnk closed this Dec 6, 2022
@dtrdnk dtrdnk reopened this Dec 6, 2022
@dtrdnk dtrdnk changed the title Fix authorizers parameters. Add some values for full example. Add env… Update LDAP parameters Dec 6, 2022
@dtrdnk dtrdnk force-pushed the master branch 3 times, most recently from 67606f2 to 750a0af Compare December 10, 2022 08:50
* Add few new parameters in 03-ldap-values.yaml for test
* Add envFrom for loading env from secrets, and subsets them
* Upgrade app version
* Fix format for nifi.provenance.repository.debug.frequency
* Add comments for ingress in values.yaml
* Fix hardcoded busybox image tag in ca app
* Fix hardcoded ldap parameters in authorizers.xml
* Add logback.xml for log level
* Fix hardcode and add new parameters in login-identity-providers-ldap.xml
* Update hardcode and add new parameters in nifi.properties
* Replace command cat to envsubst for using env vars aka source of params in configs
* Update app version
* Add clusterDomain aka global parameter
* Update README
* Remove file-provider in authorizers.xml, and set composite-configurable-user-group-provider
* fix hardcoded schema for registry url
* fix sa name for nifi app
repository: apache/nifi
tag: "1.16.3"
pullPolicy: "IfNotPresent"
repository: dmitriidmnk/nifi
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not using apache/nifi

httpsPort: 8443
webProxyHost: # <clusterIP>:<NodePort> (If Nifi service is NodePort or LoadBalancer)
webProxyHost: # 'nifi.default.svc.cluster.local:8443' uncomment and edit, if replicaCount more than 1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be the domain name for the ingress.

Copy link
Contributor

@cf250024 cf250024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest to make the only changes to address the problems we face with ldap. Remove those changes related to ingress for example. I have trouble to make ldap working for me and I'm looking for any fixed related to this. Thanks.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Breaks site-to-site test, when upgrade app version from 1.16.3 to 1.19.0
3 participants