Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix syntax error in conformance doc #336

Closed
erget opened this issue Aug 24, 2021 · 3 comments · Fixed by #337
Closed

Fix syntax error in conformance doc #336

erget opened this issue Aug 24, 2021 · 3 comments · Fixed by #337

Comments

@erget
Copy link
Member

erget commented Aug 24, 2021

When merging #326 a syntax error was introduced, which I have now corrected. @davidhassell would you mind cross-checking? Artefacts will be stored in the associated PR.
@erget erget added the style label Aug 24, 2021
@erget erget mentioned this issue Aug 24, 2021
Merged
@davidhassell
Copy link
Contributor

Thanks, @erget. I'm not sure what was introduced before, but adding the label looks good to me.

@erget
Copy link
Member Author

erget commented Aug 24, 2021

Hi @davidhassell yes, I should have described better what I was trying to fix. Without a label it wasn't being recognised as a header - one saw the === as text rather than as a modifier of the chapter heading. I've checked the new build artefacts and with the label it looks as I would expect it to. Would you like me to merge it?

@davidhassell
Copy link
Contributor

Got it, thanks. Please merge!

@erget erget linked a pull request Aug 24, 2021 that will close this issue
Fix syntax error #337
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix syntax error erget/cf-conventions
2 participants
@erget @davidhassell