Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error in canonical units of mole_concentration_of_dissolved_organic_nitrogen_in_sea_water #196

Closed
JonathanGregory opened this issue May 4, 2023 · 4 comments
Labels
accepted Agreed for inclusion in the next release of the standard name table or other controlled vocabulary defect Error or typo in standard names or other controlled vocabulary standard name (added by template) Requests and discussions for standard names and other controlled vocabulary

Comments

@JonathanGregory
Copy link
Contributor

The canonical unit of mole_concentration_of_dissolved_organic_nitrogen_in_sea_water is given as mol/m3. It's the only standard name with this units string, whereas there are 161 with mol m-3, so I think it should be changed to conform. Thanks.

@JonathanGregory JonathanGregory added standard name (added by template) Requests and discussions for standard names and other controlled vocabulary add to cfeditor (added by template) Moderators are requested to add this proposal to the CF editor labels May 4, 2023
@github-actions
Copy link

github-actions bot commented May 4, 2023

Thank you for your proposal. These terms will be added to the cfeditor (http://cfeditor.ceda.ac.uk/proposals/1) shortly. Your proposal will then be reviewed and commented on by the community and Standard Names moderator.

@JonathanGregory JonathanGregory added the defect Error or typo in standard names or other controlled vocabulary label May 9, 2023
@github-actions
Copy link

github-actions bot commented Jun 9, 2023

This issue has had no activity in the last 30 days. Accordingly:

  • If you proposed this issue or have contributed to the
    discussion, please reply to any outstanding concerns.
  • If there has been little or no discussion, please comment
    on this issue, to assist with reaching a decision.
  • If the proposal seems to have come to a consensus, please
    wait for the moderators to take the next steps towards
    acceptance.

Standard name moderators are also reminded to review @feggleton @japamment

@github-actions github-actions bot added the moderator attention (added by GitHub action) Moderators are requested to consider this issue label Jun 9, 2023
@japamment
Copy link
Member

@JonathanGregory

I agree that the current units string for this name is a typo. There have been no objections to this proposal, therefore I am accepting it and the change will be included in V82 of the standard name table, currently in preparation.

Best wishes

Alison

@japamment japamment added accepted Agreed for inclusion in the next release of the standard name table or other controlled vocabulary and removed add to cfeditor (added by template) Moderators are requested to add this proposal to the CF editor moderator attention (added by GitHub action) Moderators are requested to consider this issue labels Jul 5, 2023
@japamment
Copy link
Member

I am closing this issue as the units were corrected in V82 of the standard name table.

@japamment japamment transferred this issue from cf-convention/discuss Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Agreed for inclusion in the next release of the standard name table or other controlled vocabulary defect Error or typo in standard names or other controlled vocabulary standard name (added by template) Requests and discussions for standard names and other controlled vocabulary
Projects
None yet
Development

No branches or pull requests

2 participants