Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong signature in assertions documentation #1017

Closed
JpOnline opened this issue Aug 4, 2017 · 4 comments
Closed

Wrong signature in assertions documentation #1017

JpOnline opened this issue Aug 4, 2017 · 4 comments
Labels
docs fun-size pull-request-wanted

Comments

@JpOnline
Copy link

JpOnline commented Aug 4, 2017 •
edited
Loading

After the .isExtensibleObject, all the methods miss the optional message parameter in the documentation.
@keithamus
Copy link
Member

Thanks for the issue @JpOnline! Want to make a PR to fix this?

@Hpauric
Copy link
Contributor

Hpauric commented Aug 8, 2017

Hey, I can make those fixes, if that suits? Looks like .ifError(object) is missing the optional message parameter also.

@keithamus
Copy link
Member

Sounds great 👌. Look forward to seeing the PR @Hpauric

@Hpauric Hpauric mentioned this issue Aug 9, 2017
Merged
@meeber
Copy link
Contributor

meeber commented Aug 10, 2017

Fixed by #1023

@meeber meeber closed this as completed Aug 10, 2017
@Alhadis Alhadis mentioned this issue Aug 31, 2017
Merged
@snyk-bot snyk-bot mentioned this issue Jan 29, 2020
Open
@snyk-bot snyk-bot mentioned this issue Mar 15, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
docs fun-size pull-request-wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@keithamus @JpOnline @meeber @Hpauric