-
-
Notifications
You must be signed in to change notification settings - Fork 698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Removed phantomjs dependency #1204
Conversation
BREAKING CHANGE: Added support for chrome headless Signed-off-by: ossdev07 <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #1204 +/- ##
=======================================
Coverage 94.51% 94.51%
=======================================
Files 32 32
Lines 1676 1676
Branches 404 404
=======================================
Hits 1584 1584
Misses 92 92 Continue to review full report at Codecov.
|
Ping @keithamus @meeber Can you please have a look at this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ossdev07. Seems like a good idea to me.
Pinging @chaijs/chai.
Edit: Regarding the commit message: I'd consider this chore
instead of feat
. Would also prefer to squash commits before or during merge.
Agreed. Also not a breaking change - the code is still the same. |
Thanks, for approving this PR. |
BREAKING CHANGE: Added support for chrome headless
Phantomjs is an unmaintained project, removed phantomjs dependency from package.json, karma.conf.js, and Makefile. Added chrome headless support in package.json, karma.conf.js, and Makefile.
package-lock.json file got updated whenever we run the package.
Signed-off-by: ossdev07 [email protected]