Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Removed phantomjs dependency #1204

Merged
merged 3 commits into from
Nov 9, 2018
Merged

Conversation

ossdev07
Copy link
Contributor

BREAKING CHANGE: Added support for chrome headless
Phantomjs is an unmaintained project, removed phantomjs dependency from package.json, karma.conf.js, and Makefile. Added chrome headless support in package.json, karma.conf.js, and Makefile.
package-lock.json file got updated whenever we run the package.

Signed-off-by: ossdev07 [email protected]

BREAKING CHANGE: Added support for chrome headless

Signed-off-by: ossdev07 <[email protected]>
@ossdev07 ossdev07 requested a review from a team as a code owner October 16, 2018 10:30
@codecov
Copy link

codecov bot commented Oct 16, 2018

Codecov Report

Merging #1204 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1204   +/-   ##
=======================================
  Coverage   94.51%   94.51%           
=======================================
  Files          32       32           
  Lines        1676     1676           
  Branches      404      404           
=======================================
  Hits         1584     1584           
  Misses         92       92

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26c8a79...dbbf05b. Read the comment docs.

@ossdev07
Copy link
Contributor Author

Ping @keithamus @meeber

Can you please have a look at this PR.
It will be a delight to see phantomjs removed from chai.

Copy link
Contributor

@meeber meeber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ossdev07. Seems like a good idea to me.

Pinging @chaijs/chai.

Edit: Regarding the commit message: I'd consider this chore instead of feat. Would also prefer to squash commits before or during merge.

@keithamus keithamus merged commit 929c109 into chaijs:master Nov 9, 2018
@keithamus
Copy link
Member

Agreed. Also not a breaking change - the code is still the same.

@ossdev07
Copy link
Contributor Author

@keithamus @meeber

Thanks, for approving this PR.

This was referenced Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants