Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chai.version field is incorrect #1525

Closed
burnall opened this issue Jul 3, 2023 · 8 comments
Closed

chai.version field is incorrect #1525

burnall opened this issue Jul 3, 2023 · 8 comments

Comments

@burnall
Copy link

burnall commented Jul 3, 2023

The runtime Chai version is set to '4.3.3', though the current version is 4.3.7.
Please see https://github.com/chaijs/chai/blob/4.x.x/chai.js#L17C18-L17C18
It seems it should be updated with every release.

@voxpelli
Copy link

Same goes for the 5.x.x branch, it also references 4.3.3:

export const version = '4.3.3';

@keithamus
Copy link
Member

PRs welcome 😄

@voxpelli
Copy link

@keithamus How is it meant to work? Normally when it’s needed I read it from the package.json rather than hard code it, would that work?

@keithamus
Copy link
Member

We need to support browser environments which cannot read from the disk. Frankly I think we can just drop it from v5 as it serves little value.

@peanutenthusiast
Copy link

Hi @keithamus! Is this issue still open to PR's?

@keithamus
Copy link
Member

Yes, please go right ahead.

@peanutenthusiast
Copy link

Great. Would you mind clarifying the expected change? Just to update to '4.3.7'? Or drop given the previous comment.

@koddsson
Copy link
Member

koddsson commented Nov 3, 2023

We've removed chai version in #1550.

@koddsson koddsson closed this as completed Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants