Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Node trait for Clementine #3

Open
jfldde opened this issue Sep 30, 2024 · 5 comments · May be fixed by #22
Open

Implement Node trait for Clementine #3

jfldde opened this issue Sep 30, 2024 · 5 comments · May be fixed by #22
Assignees

Comments

@jfldde
Copy link
Collaborator

jfldde commented Sep 30, 2024

No description provided.

@kalyberk
Copy link

kalyberk commented Oct 1, 2024

Hey @jfldde, what exactly is needed here? Could you please elaborate further?

@jfldde
Copy link
Collaborator Author

jfldde commented Oct 3, 2024

Hey @kalyberk, not too sure about how Clementine will be used. Is it a binary that needs to be spawned ? If yes, we'll need to implement the Node trait on it to handle spawning, starting, cleaning it up, etc.
If not, please explain how it should be integrated

@ceyhunsen
Copy link
Member

ceyhunsen commented Oct 3, 2024

@jfldde it is possible to spawn Clementine servers (operator, verifier and aggregator) using it's single binary or using their spawner functions. Currently no Docker image, though.

@ekrembal and I were talking about this other day: Citrea may not need to spawn Clementine to test it's e2e infrastructure. Because it only moves funds between Citrea and Bitcoin, Citrea doesn't need this functionality to test reliably.

Still, if this is needed I could look into this. It should just look like Citrea's sequencer spawner etc.

@ceyhunsen ceyhunsen self-assigned this Oct 3, 2024
@kalyberk
Copy link

kalyberk commented Oct 6, 2024

@jfldde My information base on Clementine is pretty limited, especially regarding the implementation. I believe @ceyhunsen 's assistance on this issue would be more useful than mine, so, I'm de-assigning myself from the issue. Feel free to ask me anything about the bridge backend itself.

@kalyberk kalyberk removed their assignment Oct 6, 2024
@ceyhunsen
Copy link
Member

We discussed this issue with @eyusufatik and we will be implementing support for spawning Clementine servers. This repo will have tests that run nightly to check if whole infrastructure works as expected. I will be implementing this whenever I find time.

A new issue probably needs to be opened for these tests but I don't have full details and is a bit early for it. Once we closed all the current issues, we can look into this.

@ceyhunsen ceyhunsen linked a pull request Oct 11, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants