Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explore Knip and remove ts-prune #2092

Closed
sungik-choi opened this issue Mar 18, 2024 · 3 comments ยท Fixed by #2418
Closed

Explore Knip and remove ts-prune #2092

sungik-choi opened this issue Mar 18, 2024 · 3 comments ยท Fixed by #2418
Assignees
@babycroc
Labels
chore:system Issue or PR regarding source environment (e.g. lints, tests), not the actual source code

Comments

@sungik-choi
Copy link
Contributor

Description

Explore Knip and remove ts-prune

Reasons for suggestion

๐Ÿšจ ts-prune is going into maintanence mode
Please use knip which carries on the spirit.
(https://github.com/nadeesha/ts-prune)

ts-prune ๋ฉ”์ธํ…Œ์ด๋„ˆ๊ฐ€ ๋” ์ด์ƒ ๊ฐœ๋ฐœ๋˜์ง€ ์•Š๊ณ , knip์„ ๋Œ€์‹  ์‚ฌ์šฉํ•˜๋ผ๊ณ  ํ•ฉ๋‹ˆ๋‹ค.

Proposed solution

knip ๋ผ์ด๋ธŒ๋Ÿฌ๋ฆฌ ์ ์šฉ์ด ๊ฐ€๋Šฅํ•œ์ง€ ํ…Œ์ŠคํŠธํ•ด๋ณด๊ณ , ๊ฐ€๋Šฅํ•˜๋‹ค๋ฉด ๋งˆ์ด๊ทธ๋ ˆ์ด์…˜ํ•ฉ๋‹ˆ๋‹ค.

References

No response
@sungik-choi sungik-choi added the chore:system Issue or PR regarding source environment (e.g. lints, tests), not the actual source code label Mar 18, 2024
@yangwooseong
Copy link
Collaborator

knip์œผ๋กœ ํ…Œ์ŠคํŠธ๋ฅผ ํ•ด๋ดค์œผ๋‚˜ ts-prune๊ณผ ๋™์ž‘์„ ๋งž์ถ”๊ธฐ๊ฐ€ ์–ด๋ ค์›Œ์„œ ts-prune์— ํฐ ๋ฌธ์ œ๊ฐ€ ์ƒ๊ธฐ์ง€ ์•Š๋Š” ์ด์ƒ ๋งˆ์ด๊ทธ๋ ˆ์ด์…˜ํ•˜์ง€ ์•Š๋Š” ๊ฒƒ์œผ๋กœ ๊ฒฐ์ •

@yangwooseong yangwooseong closed this as not planned Won't fix, can't repro, duplicate, stale Jul 30, 2024
@channeltalk ChannelTalk
Copy link

channeltalk bot commented Jul 30, 2024

https://desk.channel.io/#/channels/1/team_chats/groups/1237/66a851cb48a93039264c

@channeltalk ChannelTalk
Copy link

channeltalk bot commented Jul 30, 2024

https://desk.channel.io/#/channels/1/team_chats/groups/1237/66a851cb777a3fd3d3e7

@yangwooseong yangwooseong reopened this Aug 21, 2024
@babycroc babycroc linked a pull request Aug 22, 2024 that will close this issue
Basic knip configuration to replace ts-prune #2418
Merged
6 tasks
@babycroc babycroc mentioned this issue Sep 5, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@babycroc babycroc

Labels
chore:system Issue or PR regarding source environment (e.g. lints, tests), not the actual source code
Projects
No open projects
Bezier React
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Basic knip configuration to replace ts-prune channel-io/bezier-react
3 participants
@yangwooseong @babycroc @sungik-choi