Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[census builder] improve state isolation in the validator sub-system #215

Closed
bkmartinjr opened this issue Feb 22, 2023 · 0 comments · Fixed by #237
Closed

[census builder] improve state isolation in the validator sub-system #215

bkmartinjr opened this issue Feb 22, 2023 · 0 comments · Fixed by #237
Assignees
Labels
census builder Related to the census builder tool P1 Priority 1 - Improvement with wide impact, fix within 1 week

Comments

@bkmartinjr
Copy link
Contributor

bkmartinjr commented Feb 22, 2023

The census builder validator is not sufficiently isolated from the rest of the builder. This makes it more complex than necessary (e.g., reopen of experiments), and leaves it open to possible state contamination from the build process

I recommend:

  • the validator should be driven by a subset of the ExperimentBuilder object which minimizes exposure to bugs in the build process itself. For example, the experiment handle should be off limits, as should build-time accumulators (eg., n_obs).
  • the validator should not re-use the SOMA/TileDB context, and should instead use a clean/new context, with default timestamp, so as to mimic reading behavior of (most) other users.

See discussion here.

See related #179

@pablo-gar pablo-gar added census builder Related to the census builder tool P0 Priority 0 - Critical, fix ASAP! sprint-Feb27-March10 P1 Priority 1 - Improvement with wide impact, fix within 1 week and removed P0 Priority 0 - Critical, fix ASAP! labels Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
census builder Related to the census builder tool P1 Priority 1 - Improvement with wide impact, fix within 1 week
Projects
None yet
3 participants