Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: happy logs generates bad aws cloudwatch url #3237

Merged

Conversation

jakeyheath
Copy link
Contributor

@jakeyheath jakeyheath commented Apr 17, 2024

CCIE-2685
Summary Happy logs generates bad aws cloudwatch url
Type Story Story
Status In Review

Summary

This PR fixes the default log group and also allows users to configure the log group when printing logs through the log insights feature. To change the default log group, update the .happy/config.json log_group_prefix setting.

@jakeyheath jakeyheath requested a review from a team as a code owner April 17, 2024 19:16
@jakeyheath jakeyheath requested review from dspadea, alexlokshin-czi, naihsuanshao and hspitzley-czi and removed request for a team and dspadea April 17, 2024 19:16
@jakeyheath jakeyheath enabled auto-merge (squash) April 17, 2024 19:17
@jakeyheath jakeyheath merged commit 1f976b7 into main Apr 17, 2024
31 checks passed
@jakeyheath jakeyheath deleted the CCIE-2685-happy-logs-generates-bad-aws-cloudwatch-url branch April 17, 2024 19:28
@czi-github-helper czi-github-helper bot mentioned this pull request Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants