Some chores #59
Closed
Some chores #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Originally from @em0lar s ansible and retooled to avoid unnecessary downloads by me
This should solve the issue of the mumble certificate being _always_ expired
Python virtual envs have ben flaky at best (e.g. breaking when the hosts python is updated). That's why I'd like to have a flake in here that would allow everyone to use the same ansible version and have the same setup in general.
I didn't touch the geerling guy ones since I have experienced breaking changes in the past from those roles...
n0emis
approved these changes
May 29, 2022
leona-ya
reviewed
Jun 29, 2022
| @@ -0,0 +1 @@ | |||
| use_flake | |||
There was a problem hiding this comment.
When including a flake.nix in this repo, it would be probably better to just use use flake (cf. https://github.com/direnv/direnv/blob/master/man/direnv-stdlib.1.md#use-flake-installable)
| ansible | ||
| ansible-lint | ||
| ]; | ||
| PASSWORD_STORE_DIR="~/.password-store/chaos/jetzt"; |
There was a problem hiding this comment.
I'm not sure whether to include a flake.nix in this repo. Especially L15 makes hard assumptions about the system of the persons using it. On my system e.g. the password store is not located in ~/.password-store.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes some omre or less minor chores that I've wanted to do for some time. To reduce the load I've grouped them into one PR.
Close #51