Allow the owner of a PR to downvote it #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some people might ask, why? The author can just close the PR. However, in many cases, the author may still want to default to the will of the people, instead of having someone else create another identical PR. Say, for instance, a controversial PR is opened. Many votes are collected. The owner, however, changes their mind and decides against it. If they close it, someone will just duplicate the PR and add to the confusion. This way, the author can downvote their own PR. It'll still follow the will of the people, and it'll be a lot simpler than alternatives. |
PlasmaPower
force-pushed
the
owner-downvote
branch
from
b046618
to
8204abf
Compare
loic-sharma
reviewed
May 24, 2017
| weight = get_vote_weight(api, user) | ||
| # I'm doing this just to see what will happen | ||
| # I'll revert it if it succeeds | ||
| weight = 1.0 if user.lower() == "plasmapower" else 0.0 |
There was a problem hiding this comment.
Dictator of chaosbot, @PlasmaPower ! 👏
|
We live in a autocracy now! |
This was referenced May 24, 2017
Closed
Merged
Merged
|
Lol :D it was fun 'til it lasted |
jakobbotsch
added a commit
to jakobbotsch/chaos
that referenced
this pull request
May 24, 2017
jakobbotsch
added a commit
to jakobbotsch/chaos
that referenced
this pull request
May 24, 2017
jakobbotsch
added a commit
to jakobbotsch/chaos
that referenced
this pull request
May 24, 2017
Closed
|
Democracy has collapsed. From the social engineering perspective, it is not at all comforting for the supporters of democracy |
Closed
chaosbot
added a commit
that referenced
this pull request
May 24, 2017
#153: 🗳 Bring back democracy Description: Cast your votes, they'll be pointless anyway. 😆 See #138 Our only chance of going back to some form of democracy is if this PR will get the approval of @PlasmaPower. :ok_woman: PR passed with a vote of 69 for and 2 against, with a weighted total of 1.0 and a threshold of 1.0. Vote record: @carlrosell: 1 @Dagefoerde: 1 @DasSkelett: 1 @ECrownofFire: 1 @FalseHonesty: 1 @J0hn-: 1 @L3nn0x: 1 @MCSH: 1 @MINIMAN10000: 1 @MegaApuTurkUltra: 1 @Mursaat: -1 @NDobrev: 1 @OwlyCode: 1 @PlasmaPower: 1 @TehMillhouse: 1 @Vorlent: 1 @ZeDev: 1 @andrewda: 1 @ankitiitb1069: 1 @aslafy-z: 1 @camd67: 1 @canvural: 1 @cheroma21: 1 @chipironcin: 1 @davidak: 1 @dehodson: 1 @deletescape: 1 @dorian-marchal: -1 @duci9y: 1 @dustMason: 1 @eukaryote31: 1 @evanhurd: 1 @fouxarn: 1 @frazr: 1 @gluck: 1 @gruselglatz: 1 @GuoArthur: 1 @healiha: 1 @hongaar: 1 @irrenhaus: 1 @jeiros: 1 @jerodsanto: 1 @jesshillier: 1 @jgierer12: 1 @kennytm: 1 @levthedev: 1 @litel-fr: 1 @lohner: 1 @lukeramsden: 1 @lunedis: 1 @mofosyne: 1 @mohrm: 1 @muffe: 1 @n3f4s: 1 @ontherunvaro: 1 @ozyx: 1 @paris-ci: 1 @pchauncey: 1 @pdxjohnny: 1 @perryprog: 1 @redg3ar: 1 @rhengles: 1 @richardjonathonharris: 1 @rudehn: 1 @shnist: 1 @ssawan623: 1 @tarunbatra: 1 @viktorsec: 1 @vsund: 1 @wjur: 1 @zack6849: 1
chaosbot
added a commit
that referenced
this pull request
May 24, 2017
#152: Voting threshold Description: There should be a voting threshold (it's actually a threshold on the votes _difference_). Set to 1% of repo followers (currently, that means the difference between 👍 and 👎 should be at least 12). Prevents things like #138 and #48. Maybe we can change this later to use a percentage of active contributors instead of (possibly passive) stargazers? Not sure how to calculate that atm though. :ok_woman: PR passed with a vote of 18 for and 2 against, with a weighted total of 16.0 and a threshold of 1.0. Vote record: @ECrownofFire: 1 @manawasp: -1 @Vad1mo: 1 @andrewda: 1 @bperson: 1 @chipironcin: 1 @davidak: 1 @frazr: 1 @hongaar: 1 @kurokikaze: 1 @lukeramsden: 1 @pivotal-avenkatesh: 1 @qgustavor: 1 @reddraggone9: 1 @rhengles: 1 @richardjonathonharris: 1 @rudehn: 1 @tarunbatra: -1 @viktorsec: 1 @xyproto: 1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redo of #77 with merge conflicts fixed.