Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop requiring d3 in ChartwerkPod constructor #1

Open
jonyrock opened this issue Dec 20, 2020 · 0 comments
Open

Stop requiring d3 in ChartwerkPod constructor #1

jonyrock opened this issue Dec 20, 2020 · 0 comments

Comments

@jonyrock
Copy link
Contributor

As comment says in https://github.com/chartwerk/base/blob/master/src/index.ts,

abstract class ChartwerkPod<T extends TimeSerie, O extends Options> {
// ...
  constructor(
    // maybe it's not the best idea
    protected _d3: typeof d3, 
    el: HTMLElement,
// ...
  ) {

it's not the best idea, but not "maybe". Why do you really need this d3 param?

Is it because you can't compile lib otherwise? Well, I think it doable....

@jonyrock jonyrock changed the title Stop requiring d3 in ChartwerPod constructor Stop requiring d3 in ChartwerkPod constructor Dec 20, 2020
@jonyrock jonyrock transferred this issue from chartwerk/base Dec 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant