kerndat: check support for PAGE_IS_SOFT_DIRTY #2349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The commit introducing PAGE_IS_SOFT_DIRTY has not been merged in kernel v6.7.x. fs/proc/task_mmu: report SOFT_DIRTY bits through the PAGEMAP_SCAN ioctl torvalds/linux@e6a9a2cbc13bf As a result, CRIU fails with the following error: Error (criu/pagemap-cache.c:199): pagemap-cache: PAGEMAP_SCAN: Invalid argument' Error (criu/pagemap-cache.c:225): pagemap-cache: Failed to fill cache for 63 (400000-402000)' This patch updates check_pagemap() in kerndat to check if PAGE_IS_SOFT_DIRTY is supported. Fixes: checkpoint-restore#2334 Signed-off-by: Radostin Stoyanov <[email protected]>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## criu-dev #2349 +/- ##
============================================
+ Coverage 70.47% 70.54% +0.06%
============================================
Files 133 133
Lines 33567 33636 +69
============================================
+ Hits 23658 23729 +71
+ Misses 9909 9907 -2 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commit introducing
PAGE_IS_SOFT_DIRTYhas not been merged in kernel v6.7.x, and as a result, CRIU fails with the following error:This patch updates
check_pagemap()in kerndat to also check ifPAGE_IS_SOFT_DIRTYis supported.Fixes: #2334