Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix integration tests #443

Merged
merged 1 commit into from
May 3, 2021

Conversation

zhouzhuojie
Copy link
Collaborator

@zhouzhuojie zhouzhuojie commented May 1, 2021

Description

Fix #442
The reason is that https://stackoverflow.com/a/66910240, removing MYSQL_USER set in the docker-compose file fixes the problem, note that root is automatically created.

Motivation and Context

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov-commenter
Copy link

Codecov Report

Merging #443 (8f325a3) into master (cb72a9e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #443   +/-   ##
=======================================
  Coverage   81.75%   81.75%           
=======================================
  Files          27       27           
  Lines        1611     1611           
=======================================
  Hits         1317     1317           
  Misses        214      214           
  Partials       80       80           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb72a9e...8f325a3. Read the comment docs.

@zhouzhuojie
Copy link
Collaborator Author

@jperichon @sesquipedalian-dev can you take a look and give a stamp?

BTW, a few PRs (#441 #439) are blocked by this, I'm also interested in getting the PR merge permission for flagr related repos, let me know if that works for you.

Copy link
Contributor

@sesquipedalian-dev sesquipedalian-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the fix

@ivanRylach ivanRylach merged commit 10955f9 into openflagr:master May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] integration tests are still failing
4 participants