Add default spinner speeds #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chelnak
force-pushed
the
default_spinner_speeds
branch
3 times, most recently
from
ccbfb4d
to
616aa0c
Compare
Prior to this commit spinners would use the default speed of 250 milliseconds set in the managers constructor method. This commit introduces a new concept of animation properties that allow each spinner to have it's own default speed. The speeds used come from https://wiki.tcl-lang.org/page/Text+Spinner. It is still possible to globally override the speed via the managers WithFrameDuration option.
chelnak
force-pushed
the
default_spinner_speeds
branch
from
616aa0c
to
1fbf19a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this PR spinners would use the default speed of 250 milliseconds set in the managers constructor method.
This commit introduces a new concept of animation properties that allow each spinner to have its own default speed. The speeds used come from this website.
It is still possible to globally override the speed via the managers
WithFrameDurationoption.