Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collaboration with MMDetection3D #4

Open
Tai-Wang opened this issue Jun 7, 2021 · 3 comments
Open

Collaboration with MMDetection3D #4

Tai-Wang opened this issue Jun 7, 2021 · 3 comments

Comments

@Tai-Wang
Copy link

Tai-Wang commented Jun 7, 2021

Hi, developers of BRNet,

Excited to find your project is reimplemented based on mmdet3d. It's good news that this framework benefits this community in terms of easier usage and development of research ideas.

I believe your work could bring great insights to this field, so I am wondering whether you have the willingness to contribute an implementation to MMDetection3D. I believe it could increase the impact of your work and also leave a mark on a fair and comprehensive benchmark.

We welcome any kind of contributions, so please feel free to ask us for help needed from our team. Thanks.

On behalf of the MMDet3D Development Team

Best,
Tai

@cheng052
Copy link
Owner

cheng052 commented Jun 7, 2021

Hi, Tai,

I am willing to contribute an implementation to MMDetection3D, and could you please give some guidance on how to do this.

Best,
Bowen

@Tai-Wang
Copy link
Author

Tai-Wang commented Jun 7, 2021

Great! After a brief review of the difference of this repo with mmdet3d, I think the basic structure is ok.

In my opinion, the main changes are focused on a class agnostic VoteHead, an RoI head for back-tracing and revisiting representative points and further detection as well as specific configs for your model, right? Then we can just split these important modules into different small Pull Requests (maybe about 3 PRs for above components and 1 for benchmark (readme page)) and clean them one by one.

So next, you just need to migrate the related code to mmdet3d and refine some docstrings/code styles. We can help you review your codes. Here is a basic guidance to leverage the pre-commit tool to refine your codes and contribute to open-mmlab codebases. You can also refer to our codes for the basic style and code standards. Let's get together to make the codes clearer and easier to use~

@cheng052
Copy link
Owner

cheng052 commented Jun 7, 2021

Thanks for your helpful guidance!

I will begin this work once I have time. I have a lot of work recently, sorry for the late contribution.

Keep in touch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants