Support pickle protocol version 5?

[tp2750]

I have a pickle file, that fails to load with the following error:

using Pickle
Pickle.load(open("/tmp/genomedict.pickle"))
ERROR: AssertionError: imcompatible protocol version: require version >= 5
Stacktrace:
 [1] execute!(p::Pickler{4}, #unused#::Val{Pickle.OpCodes.PROTO}, arg::UInt8)
   @ Pickle ~/.julia/packages/Pickle/ZuyWC/src/deserializer.jl:178
 [2] run!(p::Pickler{4}, op::Pickle.OpCodes.OpCode, io::IOStream)
   @ Pickle ~/.julia/packages/Pickle/ZuyWC/src/deserializer.jl:25
 [3] load(p::Pickler{4}, io::IOStream)
   @ Pickle ~/.julia/packages/Pickle/ZuyWC/src/deserializer.jl:15
 [4] load(io::IOStream; proto::Int64)
   @ Pickle ~/.julia/packages/Pickle/ZuyWC/src/deserializer.jl:10
 [5] load(io::IOStream)
   @ Pickle ~/.julia/packages/Pickle/ZuyWC/src/deserializer.jl:10
 [6] top-level scope
   @ ./timing.jl:220 [inlined]
 [7] top-level scope
   @ ./REPL[4]:0

The error appears to happen in deserializer.jl L178

execute!(p::AbstractPickle, ::Val{OpCodes.PROTO}, arg) = @assert protocol(p) >= arg "imcompatible protocol version: require version >= $arg"

If I just remove the assert, Pickle.jl actually loads the file, and as far as I can see, the result is correct.

Pickle version: [fbb45041] Pickle v0.3.1

[chengchingwen]

I haven't read the protocol 5, so I'm not sure whether it could work correctly. But since the op code rarely change the behavior, I think I can turn the error into a warning and let people try if it works.

[chengchingwen]

@tp2750 Actually, can you try load("/tmp/genomedict.pickle"); proto = 5)? It should try to load the pickle file with version 5 (and error out if there are unknown codes.

[tp2750]

Thank you for pointing out the proto keyword arg @chengchingwen. This works fine:

julia> @time genomeDictfromfile = Pickle.load(open(genomedictfile); proto=5)
  0.976258 seconds (3.02 M allocations: 123.461 MiB, 3.14% gc time, 71.09% compilation time)
DataStructures.DefaultDict{Any, Any, UnionAll} with 11 entries: