Bump AGP to 8.0.0 #294
Merged
Bump AGP to 8.0.0 #294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've seen this before sometimes and I think it might be a bug in the linter. |
chenxiaolong
approved these changes
Apr 15, 2023
|
@chenxiaolong You've pointed me the right direction searching for solution: https://docs.oracle.com/en/java/javase/19/docs/api/java.base/java/lang/Thread.html#getId()
|
chenxiaolong
added a commit
that referenced
this pull request
Apr 17, 2023
The method was deprecated in JDK 19. For uniqueness of the name given to ArchiveCommand.registerFormat(), we can just use the task name instead. Two instances of the same task will never run concurrently. Issue: #294 Signed-off-by: Andrew Gunnerson <[email protected]>
|
Ah, nice find! I only checked JDK 8 and 17. I've fixed this in #297 by avoiding using the thread ID altogether. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would correct the following deprecation warning, but it's out of my knowledge / I don't understand this: