Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add to stackage #16

Closed
simonmichael opened this issue Feb 21, 2024 · 7 comments
Closed

add to stackage #16

simonmichael opened this issue Feb 21, 2024 · 7 comments

Comments

@simonmichael
Copy link

Thanks for vty-windows! Could it be added to stackage nightly, like the other vty-* packages.

@chhackett
Copy link
Owner

@simonmichael
Oh, yes I can do that I think. I will try to get to it this weekend.

Sorry for the inconvenience, I've just never used stack before.

@simonmichael
Copy link
Author

Thank you! You can just send a PR adding it to https://github.com/commercialhaskell/stackage/blob/master/build-constraints.yaml .

@simonmichael
Copy link
Author

(Having it in stackage helps it get packaged more widely and helps with reproducible installs of vty/brick-based apps.)

@chhackett
Copy link
Owner

chhackett commented Feb 24, 2024

@simonmichael
Hello,
So I opened a PR where I added vty-windows to the same list as vty, etc. Unfortunately the check.sh script failed in CI.
So I'm not sure exactly what the process is for adding a package that can only be built on Windows. Should I just add it to the 'skipped-builds' section? Seems like the documentation could be a bit clearer for that scenario.

skipped-builds:
- hfsevents
- lzma-clib
- Win32
- Win32-notify
- windns

@simonmichael
Copy link
Author

simonmichael commented Feb 24, 2024 via email

@simonmichael
Copy link
Author

Oh, I see the commercialhaskell/stackage#7329 , currently blocked awaiting maintainer approval.

@simonmichael
Copy link
Author

commercialhaskell/stackage#7385 was also needed. vty-windows is now in stackage (nightly-2024-04-20).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants