Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

if title is false height ist not correct in setContainers #228

Open
hesst opened this issue Oct 6, 2016 · 0 comments
Open

if title is false height ist not correct in setContainers #228

hesst opened this issue Oct 6, 2016 · 0 comments

Comments

@hesst
Copy link

hesst commented Oct 6, 2016

https://github.com/chinmaymk/angular-charts/blob/master/src/angular-charts.js#L189
if title is false then the div

{{acConfig.title}}

is commented out
then getChildrenByClassname(childrens, 'ac-title') returns the last existing element from parameter childrens (thats another bug I think)
hight is sybstracted by the clientHeight of this (improper) element

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant