Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Caliptra LINT Violations #445

Closed
mborder-amd opened this issue Feb 29, 2024 · 2 comments
Closed

Caliptra LINT Violations #445

mborder-amd opened this issue Feb 29, 2024 · 2 comments

Comments

@mborder-amd
Copy link

Summary of Caliptra LINT violations attached. Several LINT issues have been addressed with RTL->RTL Formality LEC passing. Details can be found in the attachment. This issue will be used to create a PR for review.

Caliptra LINT Summary 2024.02.29 - PR.pdf
@steven-bellock
Copy link
Contributor

image

Those are parameters, not signals though :

caliptra-rtl/src/riscv_core/veer_el2/rtl/el2_param.vh

Line 18 in 8c11e46

parameter el2_param_t pt = '{
They should be two state.

@mborder-amd mborder-amd linked a pull request Mar 1, 2024 that will close this issue
445 caliptra lint violations #447
Closed
@JohnTraverAmd JohnTraverAmd removed a link to a pull request Mar 1, 2024
445 caliptra lint violations #447
Closed
@calebofearth
Copy link
Collaborator

Resolved by #483

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@steven-bellock @calebofearth @mborder-amd