Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

about/LICENSE over-ride in build recipe #19

Closed
dihm opened this issue Apr 1, 2024 · 0 comments · Fixed by #20
Closed

about/LICENSE over-ride in build recipe #19

dihm opened this issue Apr 1, 2024 · 0 comments · Fixed by #20

Comments

@dihm
Copy link
Contributor

dihm commented Apr 1, 2024

I'm trying to use setuptools-conda to vendor some dependencies for a project I'm working on and have hit a hurdle with LICENSE definitions.

In more modern python packages that use the pyproject.toml, it is valid to define the license meta-data as the license file, resulting in the entire license text being placed inside the package meta-data. One of the packages I'm trying to build uses the CC BY:SA license, which includes quotations in the text. The resulting nested quotations for the about/license entry in the recipe appears to be invalid yaml and causes the build to fail.

Looking at the conda-build docs, it appears the about/license key is exclusively for the license name and the full license text should never be in the recipe itself.

Not sure what the best option to handle these types of cases would be other than another kwarg to dist_conda allowing for manual override of the license key. If that seems a reasonable path, I can knock together a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant