Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing backgrounds cause editor crash on asset reload. #387

Open
RichardULZ opened this issue Jan 27, 2020 · 1 comment
Open

Missing backgrounds cause editor crash on asset reload. #387

RichardULZ opened this issue Jan 27, 2020 · 1 comment
Labels
bug Something isn't working

Comments

@RichardULZ
Copy link
Contributor

Describe the bug
Missing backgrounds cause editor to crash on asset reload, even if the assets have been fixed.

To Reproduce
Steps to reproduce the behavior:

  1. Delete or rename a background
  2. Asset is auto reloaded with blank white 256x256 square, (no path name).
  3. Undo the delete / rename, outside of editor, or leave it missing (fix both cases)
  4. Try to manually reload assets.
  5. Editor crash with "path" argument must be of type string. Received type undefined path.js:L39C:5

Expected behavior
Background is found and reloaded nicely, or left missing, no crash.
Dimensions and collisions are retained while the file is missing (test if they persist through save),
Actor positions are retained (currently fine, may break with #386).

Not important, perhaps text saying Background "path/name" missing inside the blank background?

Screenshots
If applicable, add screenshots to help explain your problem.
BackgroundMissingCrash
BackgroundMissingCrash2

Platform (please complete the following information):

  • OS: [Windows 10]
  • App version [1.2.1 / dev]

Additional context
Similar to #386

@RichardULZ
Copy link
Contributor Author

This no longer crashes the editor, but will not find the background again once it is replaced, tough to fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant