Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MD5 string validation #557

Merged
merged 6 commits into from
Jul 29, 2016
Merged

MD5 string validation #557

merged 6 commits into from
Jul 29, 2016

Conversation

gdraganic
Copy link
Contributor

MD5 string validation using regex.

@coveralls
Copy link

coveralls commented Jul 28, 2016

Coverage Status

Coverage increased (+0.01%) to 99.103% when pulling 6e2c7fa on gdraganic:master into b22f199 on chriso:master.

@@ -0,0 +1,10 @@
import assertString from './util/assertString';

/* eslint-disable no-control-regex */
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this lint suppression necessary?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't sure really so I followed the existing src with regex (lib/isAscii.js) which also has lint suppression.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks safe to remove :)

@chriso
Copy link
Collaborator

chriso commented Jul 28, 2016

Thanks for the PR 😄

@coveralls
Copy link

coveralls commented Jul 29, 2016

Coverage Status

Coverage increased (+0.01%) to 99.103% when pulling 065377d on gdraganic:master into b22f199 on chriso:master.

@chriso chriso merged commit 830873e into validatorjs:master Jul 29, 2016
chriso added a commit that referenced this pull request Jul 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants