Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question - events #4

Open
vardius opened this issue Feb 10, 2020 · 3 comments
Open

Question - events #4

vardius opened this issue Feb 10, 2020 · 3 comments

Comments

@vardius
Copy link

vardius commented Feb 10, 2020

Hi Chris,

I tried to find an email to contact you directly but I couldn't find any info on your profile therefore I am asking here.

I've noticed you have been using one of my packages and then decided to move on from it.

c8e6c9c#diff-16908b0605f2645dfcb4c3a8d248cef3

Could I know reasons behind it ? Any feedback related to my message-bus would be very much helpful in improving it. I don't get many users, so I would like you to devote some time and tell me as much as possible.

  • Was it to slow ?
  • Was it to much memory consuming ?
  • Why did it not meet your requirements ?
  • Did you have any issues ?
  • Is there anything you would like to see changed/improved ?
  • Do you like API of he package ?

also anything that comes to your mind.

Thanks in advance!

@chrisruffalo
Copy link
Owner

Hi!

I was using your library, which I didn't have any problems with, but I went through a period where Gudgeon was leaking memory all over the place. During that time I tried to remove every third-party dependency. I ended up with a very simple events design. It only dispatches one event at a time.

You need to understand that if Gudgeon ever sends more than like... one or two messages a second it probably mean something has gone awry. We have no use for speed (at this time).

So, no, it was nothing to do with your library at all but instead more of a paranoia on my part as I learn how to keep Golang memory consumption under control. (Reducing allocations and GC pressure.)

Thank you for getting back to me though!

@vardius
Copy link
Author

vardius commented Mar 19, 2020

Did you manage to identify memory leak ?

@chrisruffalo
Copy link
Owner

I'm not entirely sure. I was able to constrain it a lot more and in fact, over the last 50 days or so my home instance has served 4.6 million DNS requests and only inflated from about 25MB of ram to 35MB. In previous versions it would grow that much over a day or two.

I've not completely solved the issues but I can say that the situation is a lot more tenable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants