Skip to content
This repository has been archived by the owner on Sep 20, 2020. It is now read-only.

from sticky state to sticky state #248

Closed
david2tm opened this issue Sep 27, 2015 · 4 comments
Closed

from sticky state to sticky state #248

david2tm opened this issue Sep 27, 2015 · 4 comments
Assignees
Milestone

Comments

@david2tm
Copy link

I see an issue, don't know if it's on purpose, But I will try to explain.
Plunker: http://plnkr.co/edit/iovSdLG52ezYgsfn46BU

There're two sticky states (task-bar / content)

  1. Try switching for task-bar only for "a" to "b" (using buttons) you will see, that "a" exited, and "b" entered.
  2. Now from "b" to "c" - same story. And this is OK.
  3. Now, whilst task-bar.c is active, activate content.a, task-bar.c became inactive, whilst content.a activated. And this is OK.
  4. Try activating content.b. You will see that task-bar.c remains inactive, content.a exiting, content.b activates. So far, good.
  5. Now activate task-bar.d.
  6. content.b -> inactive = OK
  7. task-bar.d -> active = OK
  8. task-bar.c -> inactive = Not OK

So, is this is on purpose?
If not, I believe I can create PR with fix. [ e861901 , a635b78 ] but not sure it will work with sticky inside sticky and other complicated scenarios.

@christopherthielen
Copy link
Owner

Hi, yes that is a known bug, a dupe of #217. I think it is related to a couple other bugs, and there is an active PR #224 that may fix it.

I need to find a couple hours to really dig into this one and make sure the PR is correct.

@christopherthielen christopherthielen added this to the 0.0.15 milestone Oct 3, 2015
@christopherthielen christopherthielen self-assigned this Oct 3, 2015
@christopherthielen
Copy link
Owner

@david2tm in the meantime, see if version 0.0.13 works for you.

@christopherthielen
Copy link
Owner

@david2tm I've got a fix for this committed to master. Here's your plunker running correctly using ui-router-extras 0.0.15-pre1

http://plnkr.co/edit/gjy2WNixpKmv1Y2pQkZU?p=preview

@david2tm
Copy link
Author

david2tm commented Oct 6, 2015

Great, thanks.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants