From fce88f1aba98e93269d1efb78bf16a6484e6c9be Mon Sep 17 00:00:00 2001 From: nicolas Date: Wed, 21 Feb 2024 17:26:09 -0800 Subject: [PATCH 01/10] use tilt for ci --- .github/workflows/chroma-cluster-test.yml | 27 +++++++----- Tiltfile | 8 +++- bin/cluster-test.sh | 54 +++-------------------- k8s/dev/setup.yaml | 11 ++++- 4 files changed, 38 insertions(+), 62 deletions(-) diff --git a/.github/workflows/chroma-cluster-test.yml b/.github/workflows/chroma-cluster-test.yml index e474f43ca7d..bfc6f337e1c 100644 --- a/.github/workflows/chroma-cluster-test.yml +++ b/.github/workflows/chroma-cluster-test.yml @@ -16,8 +16,7 @@ jobs: matrix: python: ['3.8'] platform: ['16core-64gb-ubuntu-latest'] - testfile: ["chromadb/test/ingest/test_producer_consumer.py", - "chromadb/test/db/test_system.py", + testfile: ["chromadb/test/db/test_system.py", "chromadb/test/segment/distributed/test_memberlist_provider.py",] runs-on: ${{ matrix.platform }} steps: @@ -29,14 +28,20 @@ jobs: python-version: ${{ matrix.python }} - name: Install test dependencies run: python -m pip install -r requirements.txt && python -m pip install -r requirements_dev.txt - - name: Start minikube - id: minikube - uses: medyagh/setup-minikube@latest - with: - minikube-version: latest - kubernetes-version: latest - driver: docker - addons: ingress, ingress-dns - start-args: '--profile chroma-test' + - name: Install Tilt + run: | + TILT_VERSION="0.33.3" + curl -fsSL https://github.com/tilt-dev/tilt/releases/download/v$TILT_VERSION/tilt.$TILT_VERSION.linux.x86_64.tar.gz | \ + tar -xzv -C /usr/local/bin tilt + - name: Install ctlptl + run: | + CTLPTL_VERSION="0.8.20" + curl -fsSL https://github.com/tilt-dev/ctlptl/releases/download/v$CTLPTL_VERSION/ctlptl.$CTLPTL_VERSION.linux.x86_64.tar.gz | \ + tar -xzv -C /usr/local/bin ctlptl + - name: Set up kind + run: ctlptl create cluster kind --registry=ctlptl-registry + - name: Start Tilt + run: tilt ci - name: Integration Test run: bin/cluster-test.sh ${{ matrix.testfile }} + diff --git a/Tiltfile b/Tiltfile index 0d0777199f2..168cc11584f 100644 --- a/Tiltfile +++ b/Tiltfile @@ -21,7 +21,7 @@ docker_build('worker', k8s_yaml(['k8s/dev/setup.yaml']) k8s_resource( - objects=['chroma:Namespace', 'memberlist-reader:ClusterRole', 'memberlist-reader:ClusterRoleBinding', 'pod-list-role:Role', 'pod-list-role-binding:RoleBinding', 'memberlists.chroma.cluster:CustomResourceDefinition','worker-memberlist:MemberList'], + objects=['chroma:Namespace', 'memberlist-reader:ClusterRole', 'memberlist-reader:ClusterRoleBinding', 'pod-list-role:Role', 'pod-list-role-binding:RoleBinding', 'memberlists.chroma.cluster:CustomResourceDefinition','worker-memberlist:MemberList', 'test-memberlist:MemberList'], new_name='k8s_setup', labels=["infrastructure"] ) @@ -37,5 +37,11 @@ k8s_yaml(['k8s/dev/coordinator.yaml']) k8s_resource('coordinator', resource_deps=['pulsar', 'server', 'migration'], labels=["chroma"], port_forwards=50051 ) k8s_yaml(['k8s/dev/logservice.yaml']) k8s_resource('logservice', resource_deps=['migration'], labels=["chroma"], port_forwards='50052:50051') +k8s_resource('logservice', resource_deps=['migration'], labels=["chroma"]) +k8s_resource('pulsar', resource_deps=['k8s_setup'], labels=["infrastructure"], port_forwards=['6650:6650', '8080:8080']) +k8s_yaml(['k8s/dev/server.yaml']) +k8s_resource('server', resource_deps=['k8s_setup'],labels=["chroma"], port_forwards=8000 ) +k8s_yaml(['k8s/dev/coordinator.yaml']) +k8s_resource('coordinator', resource_deps=['pulsar', 'server'], labels=["chroma"], port_forwards=50051) k8s_yaml(['k8s/dev/worker.yaml']) k8s_resource('worker', resource_deps=['coordinator'],labels=["chroma"]) diff --git a/bin/cluster-test.sh b/bin/cluster-test.sh index d18185b8c02..94d912bc5f8 100755 --- a/bin/cluster-test.sh +++ b/bin/cluster-test.sh @@ -1,62 +1,18 @@ #!/usr/bin/env bash - set -e -function cleanup { - # Restore the previous kube context - kubectl config use-context $PREV_CHROMA_KUBE_CONTEXT - # Kill the tunnel process - kill $TUNNEL_PID - minikube delete -p chroma-test -} - -trap cleanup EXIT - -# Save the current kube context into a variable -export PREV_CHROMA_KUBE_CONTEXT=$(kubectl config current-context) - -# Create a new minikube cluster for the test -minikube start -p chroma-test - -# Add the ingress addon to the cluster -minikube addons enable ingress -p chroma-test -minikube addons enable ingress-dns -p chroma-test - -# Setup docker to build inside the minikube cluster and build the image -eval $(minikube -p chroma-test docker-env) -docker build -t server:latest -f Dockerfile . -docker build -t migration -f go/coordinator/Dockerfile.migration . -docker build -t chroma-coordinator:latest -f go/coordinator/Dockerfile . -docker build -t worker -f rust/worker/Dockerfile . --build-arg CHROMA_KUBERNETES_INTEGRATION=1 - -# Apply the kubernetes manifests -kubectl apply -f k8s/deployment -kubectl apply -f k8s/crd -kubectl apply -f k8s/cr -kubectl apply -f k8s/test - -# Wait for the pods in the chroma namespace to be ready -kubectl wait --for=condition=complete --timeout=100s job/migration -n chroma -kubectl delete job migration -n chroma -kubectl wait --namespace chroma --for=condition=Ready pods --all --timeout=400s - -# Run mini kube tunnel in the background to expose the service -minikube tunnel -c true -p chroma-test & -TUNNEL_PID=$! - -# Wait for the tunnel to be ready. There isn't an easy way to check if the tunnel is ready. So we just wait for 10 seconds -sleep 10 - export CHROMA_CLUSTER_TEST_ONLY=1 -export CHROMA_SERVER_HOST=$(kubectl get svc server -n chroma -o=jsonpath='{.status.loadBalancer.ingress[0].ip}') -export PULSAR_BROKER_URL=$(kubectl get svc pulsar-lb -n chroma -o=jsonpath='{.status.loadBalancer.ingress[0].ip}') -export CHROMA_COORDINATOR_HOST=$(kubectl get svc coordinator-lb -n chroma -o=jsonpath='{.status.loadBalancer.ingress[0].ip}') +export CHROMA_SERVER_HOST=localhost:8000 +export PULSAR_BROKER_URL=localhost +export CHROMA_COORDINATOR_HOST=localhost export CHROMA_SERVER_GRPC_PORT="50051" echo "Chroma Server is running at port $CHROMA_SERVER_HOST" echo "Pulsar Broker is running at port $PULSAR_BROKER_URL" echo "Chroma Coordinator is running at port $CHROMA_COORDINATOR_HOST" +sleep 10 + echo testing: python -m pytest "$@" python -m pytest "$@" diff --git a/k8s/dev/setup.yaml b/k8s/dev/setup.yaml index d9e1d95cc15..75478e0b6f5 100644 --- a/k8s/dev/setup.yaml +++ b/k8s/dev/setup.yaml @@ -97,4 +97,13 @@ metadata: name: worker-memberlist namespace: chroma spec: - members: \ No newline at end of file + members: +--- +apiVersion: chroma.cluster/v1 +kind: MemberList +metadata: + name: test-memberlist + namespace: chroma +spec: + members: +--- \ No newline at end of file From 899ac48ed55d6d098ccda15cc502d615b2310b10 Mon Sep 17 00:00:00 2001 From: nicolas Date: Wed, 21 Feb 2024 17:47:23 -0800 Subject: [PATCH 02/10] use tilt for test --- Tiltfile | 4 ---- bin/cluster-test.sh | 2 -- 2 files changed, 6 deletions(-) diff --git a/Tiltfile b/Tiltfile index 168cc11584f..221a00f99b8 100644 --- a/Tiltfile +++ b/Tiltfile @@ -31,10 +31,6 @@ k8s_yaml(['k8s/dev/postgres.yaml']) k8s_resource('postgres', resource_deps=['k8s_setup'], labels=["infrastructure"]) k8s_yaml(['k8s/dev/migration.yaml']) k8s_resource('migration', resource_deps=['postgres'], labels=["chroma"]) -k8s_yaml(['k8s/dev/server.yaml']) -k8s_resource('server', resource_deps=['k8s_setup'],labels=["chroma"], port_forwards=8000 ) -k8s_yaml(['k8s/dev/coordinator.yaml']) -k8s_resource('coordinator', resource_deps=['pulsar', 'server', 'migration'], labels=["chroma"], port_forwards=50051 ) k8s_yaml(['k8s/dev/logservice.yaml']) k8s_resource('logservice', resource_deps=['migration'], labels=["chroma"], port_forwards='50052:50051') k8s_resource('logservice', resource_deps=['migration'], labels=["chroma"]) diff --git a/bin/cluster-test.sh b/bin/cluster-test.sh index 94d912bc5f8..5764bcf7bf8 100755 --- a/bin/cluster-test.sh +++ b/bin/cluster-test.sh @@ -11,8 +11,6 @@ echo "Chroma Server is running at port $CHROMA_SERVER_HOST" echo "Pulsar Broker is running at port $PULSAR_BROKER_URL" echo "Chroma Coordinator is running at port $CHROMA_COORDINATOR_HOST" -sleep 10 - echo testing: python -m pytest "$@" python -m pytest "$@" From 2770db6ac5d80e59b997480149513b95c2f0d8a6 Mon Sep 17 00:00:00 2001 From: nicolas Date: Wed, 21 Feb 2024 21:52:25 -0800 Subject: [PATCH 03/10] port forwards properly --- Tiltfile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Tiltfile b/Tiltfile index 221a00f99b8..51e52c6327e 100644 --- a/Tiltfile +++ b/Tiltfile @@ -32,7 +32,7 @@ k8s_resource('postgres', resource_deps=['k8s_setup'], labels=["infrastructure"]) k8s_yaml(['k8s/dev/migration.yaml']) k8s_resource('migration', resource_deps=['postgres'], labels=["chroma"]) k8s_yaml(['k8s/dev/logservice.yaml']) -k8s_resource('logservice', resource_deps=['migration'], labels=["chroma"], port_forwards='50052:50051') +k8s_resource('logservice', resource_deps=['migration'], labels=["chroma"]) k8s_resource('logservice', resource_deps=['migration'], labels=["chroma"]) k8s_resource('pulsar', resource_deps=['k8s_setup'], labels=["infrastructure"], port_forwards=['6650:6650', '8080:8080']) k8s_yaml(['k8s/dev/server.yaml']) From 8d02e59f8c23dd42e3ac4125dec3cdd5673e7f88 Mon Sep 17 00:00:00 2001 From: nicolas Date: Wed, 21 Feb 2024 23:16:20 -0800 Subject: [PATCH 04/10] port forwards properly --- Tiltfile | 5 ++--- bin/cluster-test.sh | 2 +- k8s/dev/pulsar.yaml | 7 +++++++ 3 files changed, 10 insertions(+), 4 deletions(-) diff --git a/Tiltfile b/Tiltfile index 51e52c6327e..4d10eb060cf 100644 --- a/Tiltfile +++ b/Tiltfile @@ -33,11 +33,10 @@ k8s_yaml(['k8s/dev/migration.yaml']) k8s_resource('migration', resource_deps=['postgres'], labels=["chroma"]) k8s_yaml(['k8s/dev/logservice.yaml']) k8s_resource('logservice', resource_deps=['migration'], labels=["chroma"]) -k8s_resource('logservice', resource_deps=['migration'], labels=["chroma"]) k8s_resource('pulsar', resource_deps=['k8s_setup'], labels=["infrastructure"], port_forwards=['6650:6650', '8080:8080']) k8s_yaml(['k8s/dev/server.yaml']) -k8s_resource('server', resource_deps=['k8s_setup'],labels=["chroma"], port_forwards=8000 ) +k8s_resource('server', resource_deps=['pulsar'],labels=["chroma"], port_forwards=8000 ) k8s_yaml(['k8s/dev/coordinator.yaml']) -k8s_resource('coordinator', resource_deps=['pulsar', 'server'], labels=["chroma"], port_forwards=50051) +k8s_resource('coordinator', resource_deps=['pulsar'], labels=["chroma"], port_forwards=50051) k8s_yaml(['k8s/dev/worker.yaml']) k8s_resource('worker', resource_deps=['coordinator'],labels=["chroma"]) diff --git a/bin/cluster-test.sh b/bin/cluster-test.sh index 5764bcf7bf8..9795cba85df 100755 --- a/bin/cluster-test.sh +++ b/bin/cluster-test.sh @@ -4,7 +4,7 @@ set -e export CHROMA_CLUSTER_TEST_ONLY=1 export CHROMA_SERVER_HOST=localhost:8000 export PULSAR_BROKER_URL=localhost -export CHROMA_COORDINATOR_HOST=localhost +export CHROMA_COORDINATOR_HOST=$(kubectl get svc coordinator -n chroma -o=jsonpath='{.spec.clusterIP}') export CHROMA_SERVER_GRPC_PORT="50051" echo "Chroma Server is running at port $CHROMA_SERVER_HOST" diff --git a/k8s/dev/pulsar.yaml b/k8s/dev/pulsar.yaml index 4038ecda209..bcddf60c113 100644 --- a/k8s/dev/pulsar.yaml +++ b/k8s/dev/pulsar.yaml @@ -17,12 +17,19 @@ spec: - name: pulsar image: apachepulsar/pulsar command: [ "/pulsar/bin/pulsar", "standalone" ] + ports: - containerPort: 6650 - containerPort: 8080 volumeMounts: - name: pulsardata mountPath: /pulsar/data + readinessProbe: + httpGet: + path: /admin/v2/brokers/health + port: 8080 + initialDelaySeconds: 10 + periodSeconds: 5 volumes: - name: pulsardata emptyDir: {} From 41b4b3e0e8d64311e6b051195cb935581720412f Mon Sep 17 00:00:00 2001 From: nicolas Date: Thu, 22 Feb 2024 09:22:20 -0800 Subject: [PATCH 05/10] port forwards properly --- bin/cluster-test.sh | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/bin/cluster-test.sh b/bin/cluster-test.sh index 9795cba85df..be10be08aa9 100755 --- a/bin/cluster-test.sh +++ b/bin/cluster-test.sh @@ -4,13 +4,19 @@ set -e export CHROMA_CLUSTER_TEST_ONLY=1 export CHROMA_SERVER_HOST=localhost:8000 export PULSAR_BROKER_URL=localhost -export CHROMA_COORDINATOR_HOST=$(kubectl get svc coordinator -n chroma -o=jsonpath='{.spec.clusterIP}') +export CHROMA_COORDINATOR_HOST=localhost export CHROMA_SERVER_GRPC_PORT="50051" +kubectl port-forward svc/coordinator 50051:50051 & + + echo "Chroma Server is running at port $CHROMA_SERVER_HOST" echo "Pulsar Broker is running at port $PULSAR_BROKER_URL" echo "Chroma Coordinator is running at port $CHROMA_COORDINATOR_HOST" +kubectl -n chroma port-forward svc/coordinator 50051:50051 & + + echo testing: python -m pytest "$@" python -m pytest "$@" From ec9db1fc0e909eb608daf81968ffcdda9d1fe32f Mon Sep 17 00:00:00 2001 From: nicolas Date: Thu, 22 Feb 2024 09:48:39 -0800 Subject: [PATCH 06/10] port forwards properly --- .github/workflows/chroma-cluster-test.yml | 5 +++-- bin/cluster-test.sh | 5 ++++- k8s/dev/server.yaml | 15 ++++++++++++++- 3 files changed, 21 insertions(+), 4 deletions(-) diff --git a/.github/workflows/chroma-cluster-test.yml b/.github/workflows/chroma-cluster-test.yml index bfc6f337e1c..66cc68e6db1 100644 --- a/.github/workflows/chroma-cluster-test.yml +++ b/.github/workflows/chroma-cluster-test.yml @@ -17,7 +17,8 @@ jobs: python: ['3.8'] platform: ['16core-64gb-ubuntu-latest'] testfile: ["chromadb/test/db/test_system.py", - "chromadb/test/segment/distributed/test_memberlist_provider.py",] + "chromadb/test/ingest/test_producer_consumer.py", + "chromadb/test/segment/distributed/test_memberlist_provider.py"] runs-on: ${{ matrix.platform }} steps: - name: Checkout @@ -33,7 +34,7 @@ jobs: TILT_VERSION="0.33.3" curl -fsSL https://github.com/tilt-dev/tilt/releases/download/v$TILT_VERSION/tilt.$TILT_VERSION.linux.x86_64.tar.gz | \ tar -xzv -C /usr/local/bin tilt - - name: Install ctlptl + - name: Install ctlptlc run: | CTLPTL_VERSION="0.8.20" curl -fsSL https://github.com/tilt-dev/ctlptl/releases/download/v$CTLPTL_VERSION/ctlptl.$CTLPTL_VERSION.linux.x86_64.tar.gz | \ diff --git a/bin/cluster-test.sh b/bin/cluster-test.sh index be10be08aa9..8cce78cbc02 100755 --- a/bin/cluster-test.sh +++ b/bin/cluster-test.sh @@ -7,7 +7,6 @@ export PULSAR_BROKER_URL=localhost export CHROMA_COORDINATOR_HOST=localhost export CHROMA_SERVER_GRPC_PORT="50051" -kubectl port-forward svc/coordinator 50051:50051 & echo "Chroma Server is running at port $CHROMA_SERVER_HOST" @@ -15,6 +14,10 @@ echo "Pulsar Broker is running at port $PULSAR_BROKER_URL" echo "Chroma Coordinator is running at port $CHROMA_COORDINATOR_HOST" kubectl -n chroma port-forward svc/coordinator 50051:50051 & +kubectl -n chroma port-forward svc/pulsar 6650:6650 & +kubectl -n chroma port-forward svc/pulsar 8080:8080 & +kubectl -n chroma port-forward svc/server 8000:8000 & + echo testing: python -m pytest "$@" diff --git a/k8s/dev/server.yaml b/k8s/dev/server.yaml index 9d76314e693..c7ab13df6d8 100644 --- a/k8s/dev/server.yaml +++ b/k8s/dev/server.yaml @@ -49,4 +49,17 @@ spec: - name: chroma emptyDir: {} - +--- +apiVersion: v1 +kind: Service +metadata: + name: server + namespace: chroma +spec: + ports: + - name: server-port + port: 8000 + targetPort: 8000 + selector: + app: server + type: ClusterIP From 35604d9416444b6a5585d307833101ae305f3cd1 Mon Sep 17 00:00:00 2001 From: nicolas Date: Thu, 22 Feb 2024 10:10:30 -0800 Subject: [PATCH 07/10] port forwards properly --- .github/workflows/chroma-cluster-test.yml | 7 +++---- bin/cluster-test.sh | 17 +++++++++-------- 2 files changed, 12 insertions(+), 12 deletions(-) diff --git a/.github/workflows/chroma-cluster-test.yml b/.github/workflows/chroma-cluster-test.yml index 66cc68e6db1..171607dd3ca 100644 --- a/.github/workflows/chroma-cluster-test.yml +++ b/.github/workflows/chroma-cluster-test.yml @@ -11,7 +11,7 @@ on: workflow_dispatch: jobs: - test: + test-python: strategy: matrix: python: ['3.8'] @@ -43,6 +43,5 @@ jobs: run: ctlptl create cluster kind --registry=ctlptl-registry - name: Start Tilt run: tilt ci - - name: Integration Test - run: bin/cluster-test.sh ${{ matrix.testfile }} - + - name: Test + run: bin/cluster-test.sh bash -c 'python -m pytest "${{ matrix.testfile }}"' \ No newline at end of file diff --git a/bin/cluster-test.sh b/bin/cluster-test.sh index 8cce78cbc02..b8a4996414d 100755 --- a/bin/cluster-test.sh +++ b/bin/cluster-test.sh @@ -18,11 +18,12 @@ kubectl -n chroma port-forward svc/pulsar 6650:6650 & kubectl -n chroma port-forward svc/pulsar 8080:8080 & kubectl -n chroma port-forward svc/server 8000:8000 & - - -echo testing: python -m pytest "$@" -python -m pytest "$@" - -export CHROMA_KUBERNETES_INTEGRATION=1 -cd go/coordinator -go test -timeout 30s -run ^TestNodeWatcher$ github.com/chroma/chroma-coordinator/internal/memberlist_manager +"$@" + +# +#echo testing: python -m pytest "$@" +#python -m pytest "$@" +# +#export CHROMA_KUBERNETES_INTEGRATION=1 +#cd go/coordinator +#go test -timeout 30s -run ^TestNodeWatcher$ github.com/chroma/chroma-coordinator/internal/memberlist_manager From f077abc46decef20ede00e0b1919ddcdc51475e6 Mon Sep 17 00:00:00 2001 From: nicolas Date: Thu, 22 Feb 2024 10:23:44 -0800 Subject: [PATCH 08/10] port forwards properly --- .github/workflows/chroma-cluster-test.yml | 29 ++++++++++++++++++++++- Tiltfile | 2 ++ 2 files changed, 30 insertions(+), 1 deletion(-) diff --git a/.github/workflows/chroma-cluster-test.yml b/.github/workflows/chroma-cluster-test.yml index 171607dd3ca..3da741c713c 100644 --- a/.github/workflows/chroma-cluster-test.yml +++ b/.github/workflows/chroma-cluster-test.yml @@ -44,4 +44,31 @@ jobs: - name: Start Tilt run: tilt ci - name: Test - run: bin/cluster-test.sh bash -c 'python -m pytest "${{ matrix.testfile }}"' \ No newline at end of file + run: bin/cluster-test.sh bash -c 'python -m pytest "${{ matrix.testfile }}"' + test-go: + runs-on: '16core-64gb-ubuntu-latest' + steps: + - name: Checkout + uses: actions/checkout@v3 + - name: Set up Python ${{ matrix.python }} + uses: actions/setup-python@v4 + with: + python-version: ${{ matrix.python }} + - name: Install test dependencies + run: python -m pip install -r requirements.txt && python -m pip install -r requirements_dev.txt + - name: Install Tilt + run: | + TILT_VERSION="0.33.3" + curl -fsSL https://github.com/tilt-dev/tilt/releases/download/v$TILT_VERSION/tilt.$TILT_VERSION.linux.x86_64.tar.gz | \ + tar -xzv -C /usr/local/bin tilt + - name: Install ctlptlc + run: | + CTLPTL_VERSION="0.8.20" + curl -fsSL https://github.com/tilt-dev/ctlptl/releases/download/v$CTLPTL_VERSION/ctlptl.$CTLPTL_VERSION.linux.x86_64.tar.gz | \ + tar -xzv -C /usr/local/bin ctlptl + - name: Set up kind + run: ctlptl create cluster kind --registry=ctlptl-registry + - name: Start Tilt + run: tilt ci + - name: Test + run: bin/cluster-test.sh bash -c 'cd go/coordinator && go test -timeout 30s -run ^TestNodeWatcher$ github.com/chroma/chroma-coordinator/internal/memberlist_manager' \ No newline at end of file diff --git a/Tiltfile b/Tiltfile index 4d10eb060cf..b3747e7772d 100644 --- a/Tiltfile +++ b/Tiltfile @@ -1,3 +1,5 @@ +update_settings(max_parallel_updates=6) + docker_build('migration', context='.', dockerfile='./go/coordinator/Dockerfile.migration' From 41a55d3a352df72c621a4edb8d885bd9637e189d Mon Sep 17 00:00:00 2001 From: nicolas Date: Thu, 22 Feb 2024 10:46:32 -0800 Subject: [PATCH 09/10] port forwards properly --- bin/cluster-test.sh | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/bin/cluster-test.sh b/bin/cluster-test.sh index b8a4996414d..467478f206b 100755 --- a/bin/cluster-test.sh +++ b/bin/cluster-test.sh @@ -1,6 +1,7 @@ #!/usr/bin/env bash set -e +# TODO make url configuration consistent. export CHROMA_CLUSTER_TEST_ONLY=1 export CHROMA_SERVER_HOST=localhost:8000 export PULSAR_BROKER_URL=localhost @@ -19,11 +20,3 @@ kubectl -n chroma port-forward svc/pulsar 8080:8080 & kubectl -n chroma port-forward svc/server 8000:8000 & "$@" - -# -#echo testing: python -m pytest "$@" -#python -m pytest "$@" -# -#export CHROMA_KUBERNETES_INTEGRATION=1 -#cd go/coordinator -#go test -timeout 30s -run ^TestNodeWatcher$ github.com/chroma/chroma-coordinator/internal/memberlist_manager From e1393ef00e21fa99243f2441f2bac6bb0eff3b0e Mon Sep 17 00:00:00 2001 From: nicolas Date: Thu, 22 Feb 2024 10:49:58 -0800 Subject: [PATCH 10/10] do not install python dep --- .github/workflows/chroma-cluster-test.yml | 6 ------ 1 file changed, 6 deletions(-) diff --git a/.github/workflows/chroma-cluster-test.yml b/.github/workflows/chroma-cluster-test.yml index 3da741c713c..bdcbcc96827 100644 --- a/.github/workflows/chroma-cluster-test.yml +++ b/.github/workflows/chroma-cluster-test.yml @@ -50,12 +50,6 @@ jobs: steps: - name: Checkout uses: actions/checkout@v3 - - name: Set up Python ${{ matrix.python }} - uses: actions/setup-python@v4 - with: - python-version: ${{ matrix.python }} - - name: Install test dependencies - run: python -m pip install -r requirements.txt && python -m pip install -r requirements_dev.txt - name: Install Tilt run: | TILT_VERSION="0.33.3"