Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

btf: support CO-RE relocation of ISAv4 instructions #1213

Open
2 tasks
lmb opened this issue Nov 8, 2023 · 2 comments
Open
2 tasks

btf: support CO-RE relocation of ISAv4 instructions #1213

lmb opened this issue Nov 8, 2023 · 2 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@lmb
Copy link
Collaborator

lmb commented Nov 8, 2023

#1193 added support for new instructions. We need to extend COREFixup.Apply to recognise the new load / store modes.

Tasks

@lmb lmb added bug Something isn't working help wanted Extra attention is needed labels Nov 8, 2023
@dylandreimerink
Copy link
Member

Check what libbpf does. Did the upstream patch sets make any changes to CO-RE logic?

As far as I can find the only change to libbpf for ISAv4 is libbpf/libbpf@3d0e1c5

No changes to the core logic around that same time https://github.com/libbpf/libbpf/commits/master/src/relo_core.c

And the BPF_MEMSX constant isn't used libbpf anywhere, so it seems like no action is required.

@lmb
Copy link
Collaborator Author

lmb commented Nov 9, 2023

We'll need to adjust at least

case asm.LdXClass, asm.StClass, asm.StXClass:
to allow the new class.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants