Switch service check in the testing for the no_settings scenario
#5
Labels
blocked
This issue or pull request is awaiting the outcome of another issue or pull request
improvement
This issue or pull request will add or improve functionality, maintainability, or ease of use
test
This issue or pull request adds or otherwise modifies test code
Comments
mcdonnnj
added
blocked
|
@mcdonnnj - See pytest-dev/pytest-testinfra#767, which was released in version 10.1.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
💡 Summary
We should uncomment the test logic to use the
service.existsattribute when possible. We should remove the test that is currently in-place as a workaround when doing so.Motivation and context
Currently a workaround is used to determine whether or not a service exists due to pytest-dev/pytest-testinfra#757. If pytest-dev/pytest-testinfra#754 is merged and a new release containing it is cut we can switch to using this more straightforward check.
Implementation notes
When uncommenting the code we should also remove the existing test as it will be superfluous.
The text was updated successfully, but these errors were encountered: