Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand saved Firefox profile to full directory #62

Closed
englehardt opened this issue Apr 8, 2016 · 2 comments · Fixed by #917
Closed

Expand saved Firefox profile to full directory #62

englehardt opened this issue Apr 8, 2016 · 2 comments · Fixed by #917
Labels
enhancement Not a bug or a feature request

Comments

@englehardt
Copy link
Collaborator

Right now we restrict ourselves to just copying a few subcomponents of the profile. i.e. cookies and localStorage. Why not copy all files?

There may be some additional concerns such as extensions present in the profile directory that a user may not expect, but we can either constrain the browser configuration to be the same, or load and save the configuration alongside the profile.

@englehardt
Copy link
Collaborator Author

A full profile after a year or so of browsing can be around 500 MB. A new profile with very few page visits is around 20MB.

@englehardt englehardt added enhancement Not a bug or a feature request and removed feature-request labels Nov 6, 2020
@boolean5
Copy link
Contributor

boolean5 commented Mar 16, 2021

When we expand the saved profile to the full directory we should also consider the following:
Now, when restarting a crashed browser, we archive its profile in a tar file and then extract the contents of this tar file into the profile of a freshly started browser. Maybe we could skip this intermediate step and reuse the old profile directly instead.

Edit: moved this to its own issue (#918) as it is not trivial

boolean5 added a commit that referenced this issue May 7, 2021
Save the whole Firefox profile directory instead of only saving a few of
its subcomponents. Remove an unused import of shutil from
profile_commands.py.

Additionally, remove the `extension_port.txt` file after reading the
port from it, to prevent reading stale port information when a browser
is restarted after a crash.

Finally, remove a part of the documentation that references the old way
of dumping the profile and update a leftover reference to the
`log_directory` config option.

Closes #62.
vringar pushed a commit that referenced this issue May 7, 2021
* Save full Firefox profile

Save the whole Firefox profile directory instead of only saving a few of
its subcomponents. Remove an unused import of shutil from
profile_commands.py.

Additionally, remove the `extension_port.txt` file after reading the
port from it, to prevent reading stale port information when a browser
is restarted after a crash.

Finally, remove a part of the documentation that references the old way
of dumping the profile and update a leftover reference to the
`log_directory` config option.

Closes #62.

* Test saving full profile

Add a test that checks that attempting to save an incomplete profile
raises an error. Also, extend `test_saving` to check that a few basic
files and directories of the Firefox profile are present in the archived
profile.
Zaxeli pushed a commit to Zaxeli/OpenWPM that referenced this issue Aug 10, 2021
* Save full Firefox profile

Save the whole Firefox profile directory instead of only saving a few of
its subcomponents. Remove an unused import of shutil from
profile_commands.py.

Additionally, remove the `extension_port.txt` file after reading the
port from it, to prevent reading stale port information when a browser
is restarted after a crash.

Finally, remove a part of the documentation that references the old way
of dumping the profile and update a leftover reference to the
`log_directory` config option.

Closes openwpm#62.

* Test saving full profile

Add a test that checks that attempting to save an incomplete profile
raises an error. Also, extend `test_saving` to check that a few basic
files and directories of the Firefox profile are present in the archived
profile.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Not a bug or a feature request
Development

Successfully merging a pull request may close this issue.

2 participants