-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expand saved Firefox profile to full directory #62
Comments
A full profile after a year or so of browsing can be around 500 MB. A new profile with very few page visits is around 20MB. |
When we expand the saved profile to the full directory we should also consider the following: Edit: moved this to its own issue (#918) as it is not trivial |
Save the whole Firefox profile directory instead of only saving a few of its subcomponents. Remove an unused import of shutil from profile_commands.py. Additionally, remove the `extension_port.txt` file after reading the port from it, to prevent reading stale port information when a browser is restarted after a crash. Finally, remove a part of the documentation that references the old way of dumping the profile and update a leftover reference to the `log_directory` config option. Closes #62.
* Save full Firefox profile Save the whole Firefox profile directory instead of only saving a few of its subcomponents. Remove an unused import of shutil from profile_commands.py. Additionally, remove the `extension_port.txt` file after reading the port from it, to prevent reading stale port information when a browser is restarted after a crash. Finally, remove a part of the documentation that references the old way of dumping the profile and update a leftover reference to the `log_directory` config option. Closes #62. * Test saving full profile Add a test that checks that attempting to save an incomplete profile raises an error. Also, extend `test_saving` to check that a few basic files and directories of the Firefox profile are present in the archived profile.
* Save full Firefox profile Save the whole Firefox profile directory instead of only saving a few of its subcomponents. Remove an unused import of shutil from profile_commands.py. Additionally, remove the `extension_port.txt` file after reading the port from it, to prevent reading stale port information when a browser is restarted after a crash. Finally, remove a part of the documentation that references the old way of dumping the profile and update a leftover reference to the `log_directory` config option. Closes openwpm#62. * Test saving full profile Add a test that checks that attempting to save an incomplete profile raises an error. Also, extend `test_saving` to check that a few basic files and directories of the Firefox profile are present in the archived profile.
Right now we restrict ourselves to just copying a few subcomponents of the profile. i.e. cookies and localStorage. Why not copy all files?
There may be some additional concerns such as extensions present in the profile directory that a user may not expect, but we can either constrain the browser configuration to be the same, or load and save the configuration alongside the profile.
The text was updated successfully, but these errors were encountered: