Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed-point angle #5

Closed
PallHaraldsson opened this issue Mar 6, 2021 · 4 comments
Closed

Fixed-point angle #5

PallHaraldsson opened this issue Mar 6, 2021 · 4 comments

Comments

@PallHaraldsson
Copy link

Hi,

I've been thinking of making a package similar to yours. I could fork it, or reuse it, but now realize its GPLv3, so maybe I shouldn't look at it more in case... I want to use a different license.

Anyway, I think you're doing standard stuff, except for polar form, what was my thought too, and then some extra ideas to overcome the cons. I know the pros and cons, but it seems your implementation forces the angle to be of the same type. Am I wrong?

@cjdoris
Copy link
Owner

cjdoris commented Mar 14, 2021

Hi, sorry just noticed this. I'm going to relicense all my repos to MIT. You're welcome to contribute to this one.

The complex logarithmic numbers could definitely be improved. I don't think anybody uses them, myself included, so have considered just removing them.

@cjdoris
Copy link
Owner

cjdoris commented Mar 21, 2022

Closed because I've removed the complex logarithmics, for simplicity. I'm not aware of anyone using them.

@PallHaraldsson
Copy link
Author

Good to know, if I needed this. Do you need to update version because of semver? Or would that only apply after 1.0 (or if you had actual suspected users of CL...).

@cjdoris
Copy link
Owner

cjdoris commented Mar 21, 2022

Yeah I'll release a new version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants