Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid value returned by editor.getCommandKeystroke for commands with capital letters #523

Closed
msamsel opened this issue Jun 19, 2017 · 0 comments
Closed

Invalid value returned by editor.getCommandKeystroke for commands with capital letters #523

msamsel opened this issue Jun 19, 2017 · 0 comments
Assignees
@msamsel
Labels
status:confirmed An issue confirmed by the development team. type:bug A bug.
Milestone
4.7.1

Comments

@msamsel
Copy link
Contributor

msamsel commented Jun 19, 2017 •
edited
Loading

Are you reporting a feature or a bug?

BUG

Provide detailed reproduction steps (if any)

  1. Open browser console.
  2. Execute: CKEDITOR.instances.editor.getCommand( 'selectAll' )
  3. It should return command. We have sure that command exists.
  4. Execute CKEDITOR.instances.editor.keystrokeHandler.keystrokes
  5. It should return an array of keystroke's. So we have sure that selectAll exists and is registered by editor
  6. Execute CKEDITOR.instances.editor.getCommandKeystroke( CKEDITOR.instances.editor.getCommand('selectAll') )
  7. It returns null, for command which has returned assigned keystroke.

Expected result

possibility to obtain commandKeystroke based on command name.

Actual result

There is no command

Other details

  • CKEditor version: 4.7.0
  • Installed CKEditor plugins: full
@msamsel msamsel mentioned this issue Jun 19, 2017
Closed
@msamsel msamsel added this to the 4.7.2 milestone Jun 19, 2017
@msamsel msamsel added the type:bug A bug. label Jun 19, 2017
@msamsel msamsel self-assigned this Jun 19, 2017
@msamsel msamsel added the status:confirmed An issue confirmed by the development team. label Jun 19, 2017
@msamsel msamsel mentioned this issue Jun 19, 2017
Merged
2 tasks
@msamsel msamsel modified the milestones: 4.7.1, 4.7.2 Jun 20, 2017
@mlewand mlewand changed the title Cannot obtain commandKeystroke from the editor editor.getCommandKeystroke returns invalid value for commands with capital letters Jun 22, 2017
@mlewand mlewand changed the title editor.getCommandKeystroke returns invalid value for commands with capital letters Invalid value returned by editor.getCommandKeystroke for commands with capital letters Jun 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@msamsel msamsel

Labels
status:confirmed An issue confirmed by the development team. type:bug A bug.
Projects
None yet
Milestone
4.7.1
Development

No branches or pull requests
1 participant
@msamsel