Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typing into selected table throws an error #867

Closed
Comandeer opened this issue Sep 5, 2017 · 2 comments
Closed

Typing into selected table throws an error #867

Comandeer opened this issue Sep 5, 2017 · 2 comments
Assignees
Labels
plugin:tableselection The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. target:minor Any docs related issue that can be merged into a master or major branch. type:bug A bug.
Milestone

Comments

@Comandeer
Copy link
Member

Are you reporting a feature request or a bug?

Bug

Provide detailed reproduction steps (if any)

  1. Open https://sdk.ckeditor.com/samples/table.html
  2. Select whole table using elements path.
  3. Type any letter.

Expected result

Table is replaced with typed text.

Actual result

Table is replaced with typed text, but at the same moment error is thrown:

Uncaught TypeError: Cannot read property 'type' of null

Other details

  • CKEditor version: 4.7.0+
  • Installed CKEditor plugins: tableselection
@Comandeer Comandeer added plugin:tableselection The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. type:bug A bug. labels Sep 5, 2017
@Comandeer Comandeer self-assigned this Sep 5, 2017
@mlewand mlewand modified the milestones: master, 4.7.3 Sep 6, 2017
@mlewand mlewand added the target:minor Any docs related issue that can be merged into a master or major branch. label Sep 6, 2017
@Comandeer
Copy link
Member Author

Comandeer commented Sep 7, 2017

It seems that the proposed fix introduced new issue:

  1. Open CKEditor sample.
  2. Open browser's console.
  3. Clear the editor's content.
  4. Insert table with nested table.
  5. Select outer table.
  6. Blur the editor.
  7. Refocus the editor, but doesn't change the selection.
  8. Press Delete.

Expected result:

Table is removed.

Actual result:

Table is removed, but there are warnings in the console:

[CKEDITOR] Error code: range-startcontainer.

Error code: range-endcontainer.

@Comandeer Comandeer reopened this Sep 7, 2017
@mlewand
Copy link
Contributor

mlewand commented Sep 7, 2017

The reason for above is #873, still I'll extract this issue to #874 so that we can track its progress.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugin:tableselection The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. target:minor Any docs related issue that can be merged into a master or major branch. type:bug A bug.
Projects
None yet
Development

No branches or pull requests

2 participants