Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CommonJS or AMD dependencies can cause optimization bailouts warning. #423

Open
cami-dev opened this issue Jun 12, 2024 · 0 comments
Open

Comments

@cami-dev
Copy link

cami-dev commented Jun 12, 2024

I keep getting this warning when I run our angular library in an angular application. The library itself has ckeditor as peerdependency and has compenents that uses ckeditor, so the app installs ckeditor in their own package.json. I'm trying to understand why this warning occurs and what I understand it's saying that ckeditor is not built on ECMAScript modules?

Warning: libname.mjs depends on '@ckeditor/ckeditor5-build-classic'. CommonJS or AMD dependencies can cause optimization bailouts. For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

I can silence this by adding the following to the angular.json, but should this really happen? As I understood ckeditor is using ESmodules, or is it not?
"allowedCommonJsDependencies": [
"ckeditor"
]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant