Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Absolute font-size doesn't scale on text resizing #17416

Open
mfranzke opened this issue Nov 7, 2024 · 1 comment · May be fixed by #17417 or #17476
Open

Absolute font-size doesn't scale on text resizing #17416

mfranzke opened this issue Nov 7, 2024 · 1 comment · May be fixed by #17417 or #17476
Labels
status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it.

Comments

@mfranzke
Copy link

mfranzke commented Nov 7, 2024 •
edited
Loading

The "powered by" text gets defined with an absolute font-size or in other words by a pixel value. This should be a relative value like all others as it doesn't scale (upwards) nicely on users setting bigger font-sizes in their environments for accessibility reasons.

https://github.com/ckeditor/ckeditor5/blob/master/packages/ckeditor5-ui/theme/globals/_poweredby.css#L38
mfranzke added a commit to mfranzke/ckeditor5 that referenced this issue Nov 7, 2024
@mfranzke
fix: switched to relative font-size
67a6b8d 
Resolves ckeditor#17416
@mfranzke mfranzke linked a pull request Nov 7, 2024 that will close this issue
Open
@Greatowen42

This comment has been minimized.

Sign in to view
@pszczesniak pszczesniak linked a pull request Nov 15, 2024 that will close this issue
Open
@CKEditorBot CKEditorBot added the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: switched to relative font-size mfranzke/ckeditor5
Badges improvements. ckeditor/ckeditor5
3 participants
@mfranzke @CKEditorBot @Greatowen42